Skip to content

Add remote-storage service #3836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yurishkuro merged 9 commits into from
Aug 2, 2022
Merged

Add remote-storage service #3836

yurishkuro merged 9 commits into from
Aug 2, 2022

Conversation

@yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Aug 1, 2022 •
edited
Loading

Part of #3835

  • add tests

@yurishkuro yurishkuro mentioned this pull request Aug 1, 2022
Closed
4 tasks
@codecov
Copy link

codecov bot commented Aug 1, 2022 •
edited
Loading

Codecov Report

Merging #3836 (487f0d4) into main (ea71bd1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #3836    +/-   ##
========================================
  Coverage   97.62%   97.63%            
========================================
  Files         291      293     +2     
  Lines       16955    17067   +112     
========================================
+ Hits        16553    16663   +110     
- Misses        317      319     +2     
  Partials       85       85
Impacted Files Coverage Δ
ports/ports.go 100.00% <ø> (ø)
cmd/remote-storage/app/flags.go 100.00% <100.00%> (ø)
cmd/remote-storage/app/server.go 100.00% <100.00%> (ø)
pkg/tenancy/grpc.go 100.00% <100.00%> (ø)
plugin/storage/grpc/options.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.55% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea71bd1...487f0d4. Read the comment docs.

@yurishkuro
Add remote-storage service
ecbd6ab 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
implement
cc436c8 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
cef2bc4 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
aba6f0d 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
tests
8e0a318 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
fix
79375c3 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
tests
81fcfee 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
spell
487f0d4 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro marked this pull request as ready for review August 2, 2022 02:51
@yurishkuro yurishkuro requested a review from a team as a code owner August 2, 2022 02:51
@yurishkuro yurishkuro requested a review from pavolloffay August 2, 2022 02:51
@yurishkuro
fixes
d9e1968 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 4daa4e9 into jaegertracing:main Aug 2, 2022
@yurishkuro yurishkuro deleted the remote-store branch August 2, 2022 04:54
@yurishkuro yurishkuro mentioned this pull request Aug 2, 2022
Closed
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Aug 8, 2022
@yurishkuro @albertteoh
Add remote-storage service (jaegertracing#3836)
19fb1c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yurishkuro