[SYCL][CUDA] Fix adapter cupti linking #17224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cupti` shouldn't be linked against the adapter, when it is the adapter is unusable if the library is not available, instead of just the tracing being affected. The code is already setup to dynamically load `cupti` so this can just be removed.
npmiller
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
npmiller
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Seanst98
approved these changes
Feb 28, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuptishouldn't be linked against the adapter, when it is the adapter is unusable if the library is not available, instead of just the tracing being affected.The code is already setup to dynamically load
cuptiso this can just be removed.