Skip to content

Fixes for table_with_settings_ui integration tests #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m7pr merged 3 commits into from
Nov 21, 2025
Merged

Fixes for table_with_settings_ui integration tests #325

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85666d1
give it up to 10 attempts to check if table is ready : P
m7pr Nov 21, 2025
3427984
Update tests/testthat/test-table_with_settings_ui.R
osenan Nov 21, 2025
bb57bcd
Update tests/testthat/test-table_with_settings_ui.R
m7pr Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions tests/testthat/test-table_with_settings_ui.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,17 @@ testthat::test_that(
name = "tws",
variant = "app_driver_tws_ui",
)
app_driver$wait_for_idle(timeout = longer_timeout)

# Wait for table content to be ready - poll until table content appears
max_attempts <- 10
for (i in seq_len(max_attempts)) {
app_driver$wait_for_idle(timeout = longer_timeout)
table_text <- app_driver$get_text("#table_with_settings-table_out_main")
if (nchar(table_text) > 0 && grepl("B: Placebo|C: Combination", table_text)) {
break
}
Sys.sleep(0.5)
}

# Check if there is an table.
testthat::expect_true(is_visible("#table_with_settings-table_out_main .rtables-container", app_driver))
Expand Down Expand Up @@ -193,7 +203,17 @@ testthat::test_that(
testthat::expect_false(is_visible("#bslib-full-screen-overlay", app_driver))

app_driver$run_js(click_expand_popup)
app_driver$wait_for_idle(timeout = longer_timeout)

# Wait for table content to be rendered in the modal - poll until content appears
max_attempts <- 10
for (i in seq_len(max_attempts)) {
app_driver$wait_for_idle(timeout = longer_timeout)
table_content <- app_driver$get_text("#table_with_settings-table_out_main")
if (nchar(table_content) > 0 && grepl("B: Placebo|C: Combination", table_content)) {
break
}
Sys.sleep(0.5)
}

table_content <- app_driver$get_text("#table_with_settings-table_out_main")

Expand Down
Loading