Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Nov 21, 2025

@m7pr m7pr added the core label Nov 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      35  66.67%   113-114, 116, 124-155
R/white_small_well.R              7       0  100.00%
TOTAL                          1124     206  81.67%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bb57bcd

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Unit Tests Summary

  1 files   16 suites   9s ⏱️
170 tests 140 ✅ 30 💤 0 ❌
281 runs  251 ✅ 30 💤 0 ❌

Results for commit bb57bcd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💔 $50.53$ $+2.91$ $0$ $0$ $0$ $0$

Results for commit 736abe2

♻️ This comment has been updated with latest results.

@osenan osenan self-assigned this Nov 21, 2025
@osenan
Copy link
Contributor

osenan commented Nov 21, 2025

Definetely, the integration machine is slower than the container running on my local machine (where all the test pass). Let's see if this make a fix

Copy link
Contributor

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest keeping only to increase 4 times the timeout

@m7pr m7pr enabled auto-merge (squash) November 21, 2025 14:35
@m7pr m7pr merged commit 74ea0c8 into main Nov 21, 2025
24 checks passed
@m7pr m7pr deleted the fix_integration branch November 21, 2025 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants