Skip to content

chore(processors): Fix linter findings for revive:exported #17081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

zak-pawel
Copy link
Collaborator

Summary

Address findings for revive:exported in plugins/processors.

As part of this effort for files from plugins/processors, the following actions were taken:

  • Type names (const, var, struct, func, etc) were changed to unexported, wherever they didn't need to be exported.
  • All remaining exported types were given comments in the appropriate form – this does not apply to exported methods that implement "known" plugin interfaces (Init |SampleConfig |Gather |Start |Stop |GetState |SetState |SetParser |SetParserFunc |SetTranslator |Probe |Add |Push |Reset |Get |Set |List |GetResolver |Apply |SetSerializer ).
  • The order of methods was organized (exported methods first, then unexported, with init at the very end).

It is only part of the bigger work (for issue: #15813).

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added the chore label May 31, 2025
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome work! One comment... It's not directly related to the PR so if you don't want to fix it here, open an issue for it at least...

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 7, 2025

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 12, 2025
@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan Jun 12, 2025
Copy link
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zak-pawel Great job!

@skartikey skartikey merged commit 7bffe32 into influxdata:master Jun 12, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.35.0 milestone Jun 12, 2025
skartikey pushed a commit to skartikey/telegraf that referenced this pull request Jun 12, 2025
skartikey pushed a commit to skartikey/telegraf that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants