-
Notifications
You must be signed in to change notification settings - Fork 5.7k
chore(processors): Fix linter findings for revive:exported
#17081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(processors): Fix linter findings for revive:exported
#17081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome work! One comment... It's not directly related to the PR so if you don't want to fix it here, open an issue for it at least...
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zak-pawel Great job!
Summary
Address findings for revive:exported in
plugins/processors
.As part of this effort for files from
plugins/processors
, the following actions were taken:const
,var
,struct
,func
, etc) were changed to unexported, wherever they didn't need to be exported.Init |SampleConfig |Gather |Start |Stop |GetState |SetState |SetParser |SetParserFunc |SetTranslator |Probe |Add |Push |Reset |Get |Set |List |GetResolver |Apply |SetSerializer
).init
at the very end).It is only part of the bigger work (for issue: #15813).
Checklist