chore(processors): Fix linter findings for revive:exported (#17081)

Author: zak-pawel

.golangci.yml

@@ -340,9 +340,6 @@ linters:
             - "**/plugins/common/**"
             - "**/plugins/outputs/**"
             - "**/plugins/parsers/**"
-            - "**/plugins/processors/**"
-            - "**/plugins/secretstores/**"
-            - "**/plugins/serializers/**"
             - "**/selfstat/**"
             - "**/serializer.go"
             - "**/testutil/**"
@@ -523,7 +520,7 @@ linters:
 
       # revive:exported
       - path: (.+)\.go$
-        text: exported method .*\.(Init |SampleConfig |Gather |Start |Stop |GetState |SetState |SetParser |SetParserFunc |SetTranslator |Probe |Add |Push |Reset |Serialize |SerializeBatch |Get |Set |List |GetResolver )should have comment or be unexported
+        text: exported method .*\.(Init |SampleConfig |Gather |Start |Stop |GetState |SetState |SetParser |SetParserFunc |SetTranslator |Probe |Add |Push |Reset |Serialize |SerializeBatch |Get |Set |List |GetResolver |Apply |SetSerializer )should have comment or be unexported
 
       # EXC0001 errcheck: Almost all programs ignore errors on these functions, and in most cases it's ok
       - path: (.+)\.go$

plugins/processors/aws_ec2/ec2.go

@@ -28,6 +28,30 @@ import (
 //go:embed sample.conf
 var sampleConfig string
 
+var allowedImdsTags = []string{
+	"accountId",
+	"architecture",
+	"availabilityZone",
+	"billingProducts",
+	"imageId",
+	"instanceId",
+	"instanceType",
+	"kernelId",
+	"pendingTime",
+	"privateIp",
+	"ramdiskId",
+	"region",
+	"version",
+}
+
+const (
+	defaultMaxOrderedQueueSize = 10_000
+	defaultMaxParallelCalls    = 10
+	defaultTimeout             = 10 * time.Second
+	defaultCacheTTL            = 0 * time.Hour
+	defaultCacheSize           = 1000
+)
+
 type AwsEc2Processor struct {
 	ImdsTags              []string        `toml:"imds_tags"`
 	EC2Tags               []string        `toml:"ec2_tags"`
@@ -50,40 +74,10 @@ type AwsEc2Processor struct {
 	cancelCleanupWorker context.CancelFunc
 }
 
-const (
-	DefaultMaxOrderedQueueSize = 10_000
-	DefaultMaxParallelCalls    = 10
-	DefaultTimeout             = 10 * time.Second
-	DefaultCacheTTL            = 0 * time.Hour
-	DefaultCacheSize           = 1000
-	DefaultLogCacheStats       = false
-)
-
-var allowedImdsTags = []string{
-	"accountId",
-	"architecture",
-	"availabilityZone",
-	"billingProducts",
-	"imageId",
-	"instanceId",
-	"instanceType",
-	"kernelId",
-	"pendingTime",
-	"privateIp",
-	"ramdiskId",
-	"region",
-	"version",
-}
-
 func (*AwsEc2Processor) SampleConfig() string {
 	return sampleConfig
 }
 
-func (r *AwsEc2Processor) Add(metric telegraf.Metric, _ telegraf.Accumulator) error {
-	r.parallel.Enqueue(metric)
-	return nil
-}
-
 func (r *AwsEc2Processor) Init() error {
 	r.Log.Debug("Initializing AWS EC2 Processor")
 
@@ -151,14 +145,19 @@ func (r *AwsEc2Processor) Start(acc telegraf.Accumulator) error {
 	}
 
 	if r.Ordered {
-		r.parallel = parallel.NewOrdered(acc, r.asyncAdd, DefaultMaxOrderedQueueSize, r.MaxParallelCalls)
+		r.parallel = parallel.NewOrdered(acc, r.asyncAdd, defaultMaxOrderedQueueSize, r.MaxParallelCalls)
 	} else {
 		r.parallel = parallel.NewUnordered(acc, r.asyncAdd, r.MaxParallelCalls)
 	}
 
 	return nil
 }
 
+func (r *AwsEc2Processor) Add(metric telegraf.Metric, _ telegraf.Accumulator) error {
+	r.parallel.Enqueue(metric)
+	return nil
+}
+
 func (r *AwsEc2Processor) Stop() {
 	if r.parallel != nil {
 		r.parallel.Stop()
@@ -376,21 +375,6 @@ func (r *AwsEc2Processor) asyncAdd(metric telegraf.Metric) []telegraf.Metric {
 	return []telegraf.Metric{metric}
 }
 
-func init() {
-	processors.AddStreaming("aws_ec2", func() telegraf.StreamingProcessor {
-		return newAwsEc2Processor()
-	})
-}
-
-func newAwsEc2Processor() *AwsEc2Processor {
-	return &AwsEc2Processor{
-		MaxParallelCalls: DefaultMaxParallelCalls,
-		TagCacheSize:     DefaultCacheSize,
-		Timeout:          config.Duration(DefaultTimeout),
-		CacheTTL:         config.Duration(DefaultCacheTTL),
-	}
-}
-
 func getTagFromDescribeTags(o *ec2.DescribeTagsOutput, tag string) string {
 	for _, t := range o.Tags {
 		if *t.Key == tag {
@@ -399,3 +383,18 @@ func getTagFromDescribeTags(o *ec2.DescribeTagsOutput, tag string) string {
 	}
 	return ""
 }
+
+func newAwsEc2Processor() *AwsEc2Processor {
+	return &AwsEc2Processor{
+		MaxParallelCalls: defaultMaxParallelCalls,
+		TagCacheSize:     defaultCacheSize,
+		Timeout:          config.Duration(defaultTimeout),
+		CacheTTL:         config.Duration(defaultCacheTTL),
+	}
+}
+
+func init() {
+	processors.AddStreaming("aws_ec2", func() telegraf.StreamingProcessor {
+		return newAwsEc2Processor()
+	})
+}

plugins/processors/aws_ec2/ec2_test.go

@@ -138,10 +138,10 @@ func TestTracking(t *testing.T) {
 
 	// Prepare and start the plugin
 	plugin := &AwsEc2Processor{
-		MaxParallelCalls: DefaultMaxParallelCalls,
-		TagCacheSize:     DefaultCacheSize,
-		Timeout:          config.Duration(DefaultTimeout),
-		CacheTTL:         config.Duration(DefaultCacheTTL),
+		MaxParallelCalls: defaultMaxParallelCalls,
+		TagCacheSize:     defaultCacheSize,
+		Timeout:          config.Duration(defaultTimeout),
+		CacheTTL:         config.Duration(defaultCacheTTL),
 		ImdsTags:         []string{"accountId", "instanceId"},
 		Log:              &testutil.Logger{},
 	}
@@ -150,7 +150,7 @@ func TestTracking(t *testing.T) {
 	// Instead of starting the plugin which tries to connect to the remote
 	// service, we just fill the cache and start the minimum mechanics to
 	// process the metrics.
-	plugin.tagCache = freecache.NewCache(DefaultCacheSize)
+	plugin.tagCache = freecache.NewCache(defaultCacheSize)
 	require.NoError(t, plugin.tagCache.Set([]byte("accountId"), []byte("123456789"), -1))
 	require.NoError(t, plugin.tagCache.Set([]byte("instanceId"), []byte("i-123456789123"), -1))
 

plugins/processors/clone/clone.go

@@ -12,10 +12,10 @@ import (
 var sampleConfig string
 
 type Clone struct {
-	NameOverride string
-	NamePrefix   string
-	NameSuffix   string
-	Tags         map[string]string
+	NameOverride string            `toml:"name_override"`
+	NamePrefix   string            `toml:"name_prefix"`
+	NameSuffix   string            `toml:"name_suffix"`
+	Tags         map[string]string `toml:"tags"`
 }
 
 func (*Clone) SampleConfig() string {

plugins/processors/converter/converter.go

@@ -20,7 +20,16 @@ import (
 //go:embed sample.conf
 var sampleConfig string
 
-type Conversion struct {
+type Converter struct {
+	Tags   *conversion     `toml:"tags"`
+	Fields *conversion     `toml:"fields"`
+	Log    telegraf.Logger `toml:"-"`
+
+	tagConversions   *conversionFilter
+	fieldConversions *conversionFilter
+}
+
+type conversion struct {
 	Measurement       []string `toml:"measurement"`
 	Tag               []string `toml:"tag"`
 	String            []string `toml:"string"`
@@ -33,16 +42,7 @@ type Conversion struct {
 	Base64IEEEFloat32 []string `toml:"base64_ieee_float32"`
 }
 
-type Converter struct {
-	Tags   *Conversion     `toml:"tags"`
-	Fields *Conversion     `toml:"fields"`
-	Log    telegraf.Logger `toml:"-"`
-
-	tagConversions   *ConversionFilter
-	fieldConversions *ConversionFilter
-}
-
-type ConversionFilter struct {
+type conversionFilter struct {
 	Measurement       filter.Filter
 	Tag               filter.Filter
 	String            filter.Filter
@@ -90,13 +90,13 @@ func (p *Converter) compile() error {
 	return nil
 }
 
-func compileFilter(conv *Conversion) (*ConversionFilter, error) {
+func compileFilter(conv *conversion) (*conversionFilter, error) {
 	if conv == nil {
 		return nil, nil
 	}
 
 	var err error
-	cf := &ConversionFilter{}
+	cf := &conversionFilter{}
 	cf.Measurement, err = filter.Compile(conv.Measurement)
 	if err != nil {
 		return nil, err