fix: terminate consumer stream on OffsetOutOfRange
#96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we encounter `OffsetOutOfRange` this means that the start offset of the stream lies outside of the range that Kafka knows. In this case we should not hot-loop and try to poll new data forever, since this is very likely NOT intended. The only use case I could come up with is to start a stream at some "yet to be produced" offset, but I fail to come up with a practical reasoning behind this as well as a method to dermine the start offset for such a use case. So most users are likely interested to subscribe to data that already exists within the system.
|
arg, I need to fix redpanda |
tustvold
approved these changes
Feb 9, 2022
crepererum
force-pushed
the
crepererum/consumer_stream_offset_out_of_range
branch
from
8515fd3 to
570b98e
Compare
crepererum
force-pushed
the
crepererum/consumer_stream_offset_out_of_range
branch
from
570b98e to
1a4e849
Compare
crepererum
deleted the
crepererum/consumer_stream_offset_out_of_range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we encounter
OffsetOutOfRangethis means that the start offset ofthe stream lies outside of the range that Kafka knows. In this case we
should not hot-loop and try to poll new data forever, since this is very
likely NOT intended.
The only use case I could come up with is to start a stream at some "yet
to be produced" offset, but I fail to come up with a practical reasoning
behind this as well as a method to dermine the start offset for such a
use case.
So most users are likely interested to subscribe to data that already
exists within the system.