feat: implement record deletion #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/deletes
branch
2 times, most recently
from
70bbddb to
7b5d7eb
Compare
crepererum
commented
Feb 9, 2022
Comment on lines
+440
to
+443
| RecordAndOffset { | ||
| record: record_2, | ||
| offset: offset_2 | ||
| }, |
There was a problem hiding this comment.
BTW: this is technically a bug since we request data >= offset_3. The bug existed since forever and the next PR will fix that bug.
crepererum
force-pushed
the
crepererum/deletes
branch
from
7b5d7eb to
3fa246b
Compare
tustvold
reviewed
Feb 12, 2022
tustvold
approved these changes
Feb 12, 2022
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct DeletePartitionResponse { |
There was a problem hiding this comment.
Same as the requests I think these should be named to make clear that they correspond to the DeleteRecords API
| Ok(()) => {} | ||
| // Redpanda does not support deletions (https://github.com/redpanda-data/redpanda/issues/1016), but we also | ||
| // don't wanna skip it unconditionally | ||
| Err(ClientError::Request(RequestError::NoVersionMatch { .. })) |
| ClientError::ServerError(ProtocolError::OffsetOutOfRange, _) | ||
| ); | ||
|
|
||
| // fetching untouched records still works, however the middle record batch is NOT half-deleted and still contains record_2 |
There was a problem hiding this comment.
Aah yes, good-ole Kafka-style UX 😆
| err, | ||
| ClientError::ServerError(ProtocolError::OffsetOutOfRange, _) | ||
| ); | ||
| let err = partition_client |
There was a problem hiding this comment.
This is wild, so if you request offset_2 it will error, but if you then fetch data it will magically return offset 2 🤯
crepererum
force-pushed
the
crepererum/deletes
branch
from
3fa246b to
304eedd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need record deletion in production, but having this operation available helps us to understand how Kafka behaves when data is truncated due to retention policies.