Skip to content

Update client and message composer to underscore funds to avoid conflicts #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2023

Conversation

adairrr
Copy link
Contributor

@adairrr adairrr commented May 21, 2023

This change ensures that the funds parameter for message composer and the client generation are underscored to avoid conflicts with variables in the messages themselves.

We should do the same for fee and memo in the future

@adairrr
Copy link
Contributor Author

adairrr commented May 21, 2023

#97

@adairrr
Copy link
Contributor Author

adairrr commented May 21, 2023

Did not pull this out into a configuration because as a non-object parameter it will have no conflicts.

@pyramation pyramation merged commit 1a2639f into hyperweb-io:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants