Skip to content

Funds naming collision #97

Closed
Closed
@adairrr

Description

@adairrr

If you have a parameter in a message called funds it collides with the funds that one can provide for the coins in the message.

Example:

pub enum AutocompounderExecuteMsg {
    ...
    /// Join vault by depositing one or more funds
    Deposit { funds: Vec<OfferAsset> },
}
export interface AutocompounderInterface extends AutocompounderReadOnlyInterface {
...
  deposit: (
    {
      funds,
    }: {
      funds: AnsAsset[]
    },
    fee?: number | StdFee | 'auto',
    memo?: string,
    funds?: Coin[]
  ) => Promise<ExecuteResult>
...
}

I propose that we rename fee, memo, and funds to their underscored variants: _fee, _memo, and _funds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions