Skip to content

perf(types): check JSONPrimitive first in JSONParsed #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yusukebe wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −12
Draft

perf(types): check JSONPrimitive first in JSONParsed #4596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/utils/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,16 @@ export type JSONValue = JSONObject | JSONArray | JSONPrimitive
* which defaults to `bigint | ReadonlyArray<bigint>`.
* You can set it to `never` to disable this check.
*/
export type JSONParsed<T, TError = bigint | ReadonlyArray<bigint>> = T extends {
toJSON(): infer J
}
? (() => J) extends () => JSONPrimitive
? J
: (() => J) extends () => { toJSON(): unknown }
? {}
: JSONParsed<J, TError>
: T extends JSONPrimitive
? T
: T extends InvalidJSONValue
? never
export type JSONParsed<T, TError = bigint | ReadonlyArray<bigint>> = T extends JSONPrimitive
? T
: T extends InvalidJSONValue
? never
: T extends { toJSON(): infer J }
? (() => J) extends () => JSONPrimitive
? J
: (() => J) extends () => { toJSON(): unknown }
? {}
: JSONParsed<J, TError>
: T extends ReadonlyArray<unknown>
? { [K in keyof T]: JSONParsed<InvalidToNull<T[K]>, TError> }
: T extends Set<unknown> | Map<unknown, unknown> | Record<string, never>
Expand Down