Skip to content

Conversation

@yusukebe
Copy link
Member

Check JSONPrimitive first, since it's used more often.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

This comment has been minimized.

@github-actions
Copy link

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 38,931.55 52,603.51 35,177.29 29,013.85
hono (current) bun 38,933.97 52,930.01 34,760.06 29,111.85
Change +0.01% +0.62% -1.19% +0.34%

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (41ee1bb) to head (eef6892).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4596   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3267     3266    -1     
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Bundle size check

main (41ee1bb) #4596 (34ab85b) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (41ee1bb) #4596 (34ab85b) +/-
Files 303 303 0
Lines 141,136 141,134 -2
Identifiers 128,893 128,893 0
Symbols 269,855 269,855 0
Types 206,536 206,536 0
Instantiations 666,325 665,701 -624
Memory used 352,492K 352,579K 87K
I/O read 0.03s 0.02s -0.01s
I/O write 0s 0s 0s
Parse time 0.64s 0.71s 0.07s
Bind time 0.27s 0.31s 0.04s
Check time 2.37s 2.87s 0.5s
Emit time 0s 0s 0s
Total time 3.28s 3.9s 0.62s

Compiler Diagnostics (typescript-go)

main (41ee1bb) #4596 (34ab85b) +/-
Files 303 303 0
Lines 141,138 141,136 -2
Identifiers 128,856 128,856 0
Symbols 392,321 388,260 -4,061
Types 378,666 378,665 -1
Instantiations 1,077,904 1,077,266 -638
Memory used 257,972K 257,281K -691K
Memory allocs 2,719,803 2,717,544 -2,259
Config time 0.001s 0.001s 0s
Parse time 0.089s 0.114s 0.025s
Bind time 0.034s 0.051s 0.017s
Check time 0.571s 0.794s 0.223s
Emit time 0s 0s 0s
Total time 0.735s 1.012s 0.277s

Reported by octocov

@yusukebe yusukebe marked this pull request as draft December 25, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants