Skip to content

Conversation

@pdaoust
Copy link
Contributor

@pdaoust pdaoust commented Dec 1, 2025

Do for main what #238 did for holochain-0.6.

Summary by CodeRabbit

  • Chores
    • Removed hc-launch from development environment and build workflows across all configuration files and project templates
    • Updated hc-scaffold to version 0.600.1
    • Removed hc-launch from GitHub Actions build matrix and eliminated the dedicated automated version update job
    • Streamlined development environment setup and dependencies

✏️ Tip: You can customize this high-level summary in your review settings.

@cocogitto-bot
Copy link

cocogitto-bot bot commented Dec 1, 2025

✔️ c73ced5...f8a3b94 - Conventional commits check succeeded.

@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

This pull request removes the hc-launch (Holochain Launch CLI) tool and its dependencies from across the entire codebase. Changes include removing hc-launch from GitHub Actions workflows, the flake.nix input declarations and all references (derivations, packages, apps, devShells, introspection), template files, and documentation. The hc-scaffold reference is also updated to v0.600.1.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/build.yaml, .github/workflows/command-listener.yaml, .github/workflows/holonix-update.yaml
Removed hc-launch from build matrix; removed entire bump_hc_launch job with all steps; removed update-launcher input and launcher bump step from holochain version update workflow
Root Configuration
flake.nix
Removed hc-launch input, derivation, and all references across packages, apps, devShells, and introspection script; updated hc-scaffold URL ref from v0.600.0 to v0.600.1
Documentation
README.md
Removed hc-launch, lair-keystore, hc-scaffold, and hn-introspect from dev shell package list
Template Files
templates/custom-holochain/flake.nix, templates/custom-rust/flake.nix, templates/default/flake.nix
Removed hc-launch from devShell package lists in all three templates

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • flake.nix requires careful verification of input removal, derivation cleanup, and reference elimination across multiple sections (packages, apps, devShells, introspection)
  • Confirm no orphaned references to hc-launch remain elsewhere in the flake
  • Validate that hc-scaffold version bump (v0.600.0 → v0.600.1) is intentional and compatible

Possibly related PRs

Suggested reviewers

  • matthme
  • ThetaSinner
  • veeso

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the two main changes: removal of deprecated hc-launch and bumping hc-scaffold to 0.600.1, which matches the raw summary and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/tooling-updates-for-main

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c372eb and f8a3b94.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (8)
  • .github/workflows/build.yaml (0 hunks)
  • .github/workflows/command-listener.yaml (0 hunks)
  • .github/workflows/holonix-update.yaml (0 hunks)
  • README.md (0 hunks)
  • flake.nix (1 hunks)
  • templates/custom-holochain/flake.nix (0 hunks)
  • templates/custom-rust/flake.nix (0 hunks)
  • templates/default/flake.nix (0 hunks)
💤 Files with no reviewable changes (7)
  • templates/custom-holochain/flake.nix
  • .github/workflows/build.yaml
  • templates/custom-rust/flake.nix
  • .github/workflows/holonix-update.yaml
  • templates/default/flake.nix
  • .github/workflows/command-listener.yaml
  • README.md
🔇 Additional comments (2)
flake.nix (2)

350-396: Clean removal of hc-launch from all exports.

The packages, apps, and devShells sections are consistent—hc-launch has been fully removed from all export surfaces. The remaining tools (holochain, hc, hcterm, bootstrap-srv, lair-keystore, hc-scaffold, hn-introspect, hc-playground, rust) are properly wired.


40-44: Version bump to v0.600.1 is correct.

The hc-scaffold input is properly updated to reference the existing v0.600.1 tag in the holochain/scaffolding repository.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pdaoust pdaoust requested a review from a team December 1, 2025 18:01
@pdaoust pdaoust merged commit 900c5cf into main Dec 1, 2025
24 checks passed
@pdaoust pdaoust deleted the chore/tooling-updates-for-main branch December 1, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants