Chore: Final bump to scaffolding 0.600.1, remove hc-launch

[pdaoust]

This gets flake.lock to the commit of scaffolding 0.600.0 v0.600.1 that scaffolds a nix flake that uses all the most up-to-date tools. It also removes the deprecated hc-launch command.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/bump-scaffolding-0.6.0-hashes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mattyg]

• hc-scaffold 0.600.1 released, so we can switch to that tag
• hc-launch will be deprecated in 0.6 and can be removed

[jost-s]

All this

holonix/flake.nix

Lines 224 to 277 in d7e5f91

	# define how to build hc-launch binary
	hc-launch =
	let
	# Crane filters out all non-cargo related files. Define include filter with files needed for build.
	nonCargoBuildFiles = path: _type: builtins.match ".*(js|json|png)$" path != null;
	includeFilesFilter = path: type:
	(craneLib.filterCargoSources path type) || (nonCargoBuildFiles path type);
	# Crane doesn't know which version to select from a workspace, so we tell it where to look
	crateInfo = craneLib.crateNameFromCargoToml { cargoToml = inputs.hc-launch + "/crates/hc_launch/src-tauri/Cargo.toml"; };
	commonArgs = {
	pname = "hc-launch";
	version = crateInfo.version;
	# Use hc-launch sources as defined in input dependencies and include only those files defined in the
	# filter previously.
	src = pkgs.lib.cleanSourceWith {
	src = inputs.hc-launch;
	filter = includeFilesFilter;
	};
	# Only build hc-launch command
	cargoExtraArgs = "--bin hc-launch";
	# commands required at build time
	nativeBuildInputs = (
	if pkgs.stdenv.isLinux then [ pkgs.pkg-config ]
	else [ ]
	);
	# build inputs required for linking to execute at runtime
	buildInputs = [
	pkgs.perl
	]
	++ (pkgs.lib.optionals pkgs.stdenv.isLinux
	[
	pkgs.glib
	pkgs.go
	pkgs.webkitgtk_4_0.dev
	]);
	# do not check built package as it either builds successfully or not
	doCheck = false;
	};
	# derivation building all dependencies
	deps = craneLib.buildDepsOnly commonArgs;
	in
	# derivation with the main crates
	craneLib.buildPackage
	(commonArgs // {
	cargoArtifacts = deps;
	stdenv = p: p.stdenv;
	});

and every occurrence of hc-launch has to be removed as well.

[pdaoust]

@jost-s okay, here's a new commit with every instance I could find of hc-launch removed. I notice there's a bit of stuff related to updating Launcher in the holonix-update.yaml build script -- should that be removed too?

[jost-s]

@pdaoust Yes, as you already did, and please delete these sections too:

holonix/.github/workflows/holonix-update.yaml

Lines 27 to 31 in eceb323

	update-launcher:
	description: "Should Launcher be updated?"
	type: boolean
	default: false
	required: true

holonix/.github/workflows/holonix-update.yaml

Lines 45 to 48 in eceb323

	update-launcher:
	type: boolean
	default: false
	required: false

[cocogitto-bot]

✔️ 4380dcd...f1fadcf - Conventional commits check succeeded.

[jost-s]

LGTM

[mattyg]

I realized that we we want to remove hc-launch on main as well.

Usually we would do a PR to main, and then backport it to main-0.6.

Maybe if its easier this time lets just merge this and then make a separate PR to remove hc-launch from main

Sorry I should have caught this last time.