Skip to content

Conversation

@beagins
Copy link
Contributor

@beagins beagins commented Mar 21, 2025

Description

ℹ️ NOTE: This branch is merging into a feature sidebranch (not main)
  • Changelog update
  • Replace Picker w/ HDS Super Select
  • Implement Refresh Namespaces Button
  • Implement Manage Namespaces Button works
  • Redirect to Namespace on click
  • Search filters Namespace list (free)

Outstanding items that will be addressed in separate PRs before the feature sidebranch is merged to main:

  • All/Matching Namespaces Label w/ Count Badge
  • Show ✔️ next to selected namespace
  • Expanded namespace picker width to support long namespace paths
  • Tab to auto-complete namespace path
  • Styling
  • Write tests
  • Manual testing

Screenshots

⚠️ NOTE: The current implementation looks ugly, styling will be addressed in a separate PR
Screenshot 2025-03-21 at 11 35 42 AM
Screenshot 2025-03-21 at 11 35 49 AM
Screenshot 2025-03-21 at 11 35 58 AM
Screenshot 2025-03-21 at 11 36 10 AM
Screenshot 2025-03-21 at 11 36 36 AM
Screenshot 2025-03-21 at 11 36 45 AM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 21, 2025
@beagins beagins added this to the 1.20.0-rc milestone Mar 21, 2025
@github-actions
Copy link

github-actions bot commented Mar 21, 2025

CI Results:
All Go tests succeeded! ✅

@beagins beagins force-pushed the VAULT-34482/namespace-picker branch 2 times, most recently from cc432f2 to 7448316 Compare March 24, 2025 23:32
zofskeez and others added 13 commits March 25, 2025 09:27
* docs: Update Seal/Unseal concept topic

* docs: Edits

* docs: Edits

* docs: Edits

* docs: Edits

* docs: Edits

* docs: Edits

* Additional edits

* Remove unnecessary sentence

---------

Co-authored-by: Yoko Hyakuna <[email protected]>
* move sync activation and capabilities from flag service to version service and components

* cleanup unnecessary args

* remove permissions service

* un-nest (some) modules

* simplify overview test so logic is easier to follow

* modal test

* update service tests

* change back to 403 because maybe it is permissions related?

* fix tests running on CE

* small cleanup

* fix logic based on feedback

* add logic for hvd specifically, update cluster tests
* generates new api client version with runtime changes for VoidResponse type and JSONApiResponse transformer update

* removes extractData middleware from api service

* converts tools/unwrap component to ts and updates to use api service

* another api client version with more tweaks to JSONApiResponse in runtime

* removes extractData test for api service
* Update the callout note for accuracy

* Change the callout type from warning to tip

* Format fixes

* Minor title update
@beagins beagins force-pushed the VAULT-34482/namespace-picker branch from 7448316 to 067008e Compare March 25, 2025 23:52
@beagins beagins deleted the branch VAULT-34216/update-namespace-picker March 25, 2025 23:57
@beagins beagins closed this Mar 25, 2025
@beagins beagins deleted the VAULT-34482/namespace-picker branch March 26, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants