Skip to content

Conversation

@zofskeez
Copy link
Contributor

Description

This PR converts the tools/hash component to ts and updates it to use the api service.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@zofskeez zofskeez added this to the 1.20.0-rc milestone Mar 24, 2025
@zofskeez zofskeez requested a review from a team as a code owner March 24, 2025 17:49
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 24, 2025
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@service declare readonly flashMessages: FlashMessageService;

@tracked algorithm = 'sha2-256';
@tracked format = 'base64';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own information, I know these files are older, but wouldn't these defaults be set by the model? And now that we're moving away from a model, they'd be set by the apiSpec? For example algorithm's default would be set by the api as 'sha2-256'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case there are no models for tools so it was just using the adapter and directly making a request. You bring up a good question about defaults. I can see that the default values for this request are defined in the OpenAPI spec, but I'm not seeing anywhere in the client where it is applying the values. I suppose that it doesn't bother populating the values if they are not required properties since the server will default the values on that end.

@zofskeez zofskeez merged commit 1d280b9 into main Mar 25, 2025
45 checks passed
@zofskeez zofskeez deleted the ui/VAULT-34861/api-tools-hash branch March 25, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants