-
Notifications
You must be signed in to change notification settings - Fork 157
L2: drip rewards from L1, introducing Reservoirs #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 91.53% // Head: 92.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## pcv/l2-bridge #701 +/- ##
=================================================
+ Coverage 91.53% 92.34% +0.80%
=================================================
Files 42 44 +2
Lines 1984 2141 +157
Branches 346 374 +28
=================================================
+ Hits 1816 1977 +161
+ Misses 168 164 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ae18852
to
5073920
Compare
8c8f6aa
to
3f6c55e
Compare
4a97ed9
to
bf56447
Compare
BREAKING CHANGE: remove setIssuanceRate from RewardsManager interface BREAKING CHANGE: RewardsDenied event now includes amount
…ear they're decoupled [L-03]
… confusion [L-10]
…o call drip (needs tests)
… L2 [H-03] [L-03]
648f54d
to
559ea00
Compare
Closing as GIP-0037 is believed to be the better alternative at this point (see https://forum.thegraph.com/t/gip-0037-the-graph-arbitrum-deployment-with-linear-rewards-minted-in-l2/3551) |
The changes from this PR correspond to GIP-0034
This is a rebased version of #571, cleaned up to only include the changes for the reservoir drip rewards distribution mechanism. Rebased on top of #699 which includes the bridge with all the audit fixes.