Skip to content

L2: drip rewards from L1, introducing Reservoirs #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 47 commits into from

Conversation

pcarranzav
Copy link
Member

The changes from this PR correspond to GIP-0034

This is a rebased version of #571, cleaned up to only include the changes for the reservoir drip rewards distribution mechanism. Rebased on top of #699 which includes the bridge with all the audit fixes.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 91.53% // Head: 92.34% // Increases project coverage by +0.80% 🎉

Coverage data is based on head (648f54d) compared to base (8aa3bd6).
Patch coverage: 99.48% of modified lines in pull request are covered.

❗ Current head 648f54d differs from pull request most recent head 559ea00. Consider uploading reports for the commit 559ea00 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           pcv/l2-bridge     #701      +/-   ##
=================================================
+ Coverage          91.53%   92.34%   +0.80%     
=================================================
  Files                 42       44       +2     
  Lines               1984     2141     +157     
  Branches             346      374      +28     
=================================================
+ Hits                1816     1977     +161     
+ Misses               168      164       -4     
Flag Coverage Δ
unittests 92.34% <99.48%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/tests/ReservoirMock.sol 66.66% <66.66%> (ø)
contracts/governance/Managed.sol 100.00% <100.00%> (+5.45%) ⬆️
contracts/l2/reservoir/L2Reservoir.sol 100.00% <100.00%> (ø)
contracts/reservoir/L1Reservoir.sol 100.00% <100.00%> (ø)
contracts/reservoir/Reservoir.sol 100.00% <100.00%> (ø)
contracts/rewards/RewardsManager.sol 100.00% <100.00%> (ø)
contracts/staking/Staking.sol 96.77% <100.00%> (+0.48%) ⬆️
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <0.00%> (ø)
contracts/tests/CallhookReceiverMock.sol

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigone tmigone added the L2 label Sep 2, 2022
@tmigone tmigone force-pushed the pcv/l2-bridge branch 2 times, most recently from ae18852 to 5073920 Compare September 7, 2022 10:15
@tmigone tmigone mentioned this pull request Sep 26, 2022
@pcarranzav pcarranzav marked this pull request as ready for review September 27, 2022 00:54
BREAKING CHANGE: remove setIssuanceRate from RewardsManager interface
BREAKING CHANGE: RewardsDenied event now includes amount
pcarranzav and others added 26 commits September 28, 2022 13:31
@pcarranzav
Copy link
Member Author

Closing as GIP-0037 is believed to be the better alternative at this point (see https://forum.thegraph.com/t/gip-0037-the-graph-arbitrum-deployment-with-linear-rewards-minted-in-l2/3551)

@pcarranzav pcarranzav closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants