feat: make GNS signal transferable #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #568 +/- ##
==========================================
- Coverage 90.58% 90.34% -0.25%
==========================================
Files 37 35 -2
Lines 1795 1760 -35
Branches 293 294 +1
==========================================
- Hits 1626 1590 -36
- Misses 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pcarranzav
reviewed
May 16, 2022
tmigone
force-pushed
the
tmigone/gns-transfer
branch
from
306652e to
dec52b9
Compare
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/gns-transfer
branch
from
dec52b9 to
40ca888
Compare
abarmat
previously approved these changes
May 19, 2022
- Remove unused return value in transferSignal [N-22] - Use single require statements in setSubgraphNFT [L-11] Signed-off-by: Tomás Migone <[email protected]>
|
Latest commit 09f40d1 addresses audit issues N-22 and L-11 |
abarmat
approved these changes
Jul 27, 2022
pcarranzav
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.thegraph.com/t/gip-0032-make-gns-signal-transferrable/3338
Motivation
From GIP32:
Changes
This PR adds a
transferSignalfunction to the GNS contract that allows a curator to transfer ownership of theirnSignalto another address.Signed-off-by: Tomás Migone [email protected]