-
Notifications
You must be signed in to change notification settings - Fork 157
feat: make GNS signal transferable #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #568 +/- ##
==========================================
- Coverage 90.58% 90.34% -0.25%
==========================================
Files 37 35 -2
Lines 1795 1760 -35
Branches 293 294 +1
==========================================
- Hits 1626 1590 -36
- Misses 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
306652e
to
dec52b9
Compare
Signed-off-by: Tomás Migone <[email protected]>
dec52b9
to
40ca888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for an audit
- Remove unused return value in transferSignal [N-22] - Use single require statements in setSubgraphNFT [L-11] Signed-off-by: Tomás Migone <[email protected]>
Latest commit 09f40d1 addresses audit issues N-22 and L-11 |
See https://forum.thegraph.com/t/gip-0032-make-gns-signal-transferrable/3338
Motivation
From GIP32:
Changes
This PR adds a
transferSignal
function to the GNS contract that allows a curator to transfer ownership of theirnSignal
to another address.Signed-off-by: Tomás Migone [email protected]