Override base image's labels #838
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive container metadata labels to the Dockerfile to improve discoverability and provide better context for the LGTM Docker image. The changes focus on standardizing the container image labels according to Kubernetes and OCI specifications.
- Adds descriptive labels following Kubernetes (io.k8s.) and OCI (org.opencontainers.image.) naming conventions
- Clears inherited labels from the base image that are not applicable to this image
- Includes TODO comment for future integration with revision and version labels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Depends on grafana/shared-workflows#1488. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Override container image labels from the base Red Hat image to use appropriate values for LGTM. Resolves #837.
Add some more labels for the image.
Consume changes from grafana/shared-workflows#1471. Signed-off-by: Martin Costello <[email protected]>
Apply custom labels to override base image labels.
martincostello
force-pushed
the
gh-837
branch
from
057800e to
dcebe67
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I guess this is going to need merging and releasing to see if it actually works, so... |
|
There's no real changes to release right now, but we should get a OTel Collector update to 0.139.0 soon so we can test it via that. |
2 participants
Override container image labels from the base Red Hat image to use appropriate values for LGTM.
Resolves #837.