Skip to content

Conversation

@martincostello
Copy link
Member

Allow custom labels to be added to container images.

Allow custom labels to be added to container images.
`labels` shouldn't be required.
Copilot AI review requested due to automatic review settings October 31, 2025 15:28
@martincostello martincostello requested a review from a team as a code owner October 31, 2025 15:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom labels to the build-push-to-dockerhub composite action. Users can now pass custom labels that will be applied to Docker images during the build process.

  • Added a new labels input parameter to the action
  • Integrated the labels input with the docker/metadata-action step
  • Updated documentation to reflect the new parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
actions/build-push-to-dockerhub/action.yaml Added labels input definition and passed it to the metadata-action step
actions/build-push-to-dockerhub/README.md Added documentation for the new labels parameter in the inputs table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address suggestions from Copilot.
@zerok
Copy link
Contributor

zerok commented Nov 4, 2025

Hey 🙂 IIRC this will soon be deprecated in favor of https://github.com/grafana/shared-workflows/tree/main/actions/docker-build-push-image . Would that action work for your use-case?

@martincostello
Copy link
Member Author

I haven't investigated migrating fully yet, but we only need pushing to Docker Hub and haven't investigated/tested other CPU architectures for the image yet. For now this is just to allow us to resolve grafana/docker-otel-lgtm#837.

@zerok
Copy link
Contributor

zerok commented Nov 5, 2025

Okidoki 🙂 Since both fields have the same name, I think it would be fine to still have that in the "old" action 😄

@zerok zerok added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 988bd06 Nov 5, 2025
22 checks passed
@zerok zerok deleted the add-labels-input branch November 5, 2025 06:52
martincostello added a commit to grafana/docker-otel-lgtm that referenced this pull request Nov 5, 2025
Consume changes from grafana/shared-workflows#1471.

Signed-off-by: Martin Costello <[email protected]>
martincostello added a commit to grafana/docker-otel-lgtm that referenced this pull request Nov 5, 2025
Consume changes from grafana/shared-workflows#1471.

Signed-off-by: Martin Costello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants