-
Notifications
You must be signed in to change notification settings - Fork 29
feat(build-push-to-dockerhub): add labels input #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow custom labels to be added to container images.
`labels` shouldn't be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom labels to the build-push-to-dockerhub composite action. Users can now pass custom labels that will be applied to Docker images during the build process.
- Added a new
labelsinput parameter to the action - Integrated the labels input with the docker/metadata-action step
- Updated documentation to reflect the new parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| actions/build-push-to-dockerhub/action.yaml | Added labels input definition and passed it to the metadata-action step |
| actions/build-push-to-dockerhub/README.md | Added documentation for the new labels parameter in the inputs table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address suggestions from Copilot.
|
Hey 🙂 IIRC this will soon be deprecated in favor of https://github.com/grafana/shared-workflows/tree/main/actions/docker-build-push-image . Would that action work for your use-case? |
|
I haven't investigated migrating fully yet, but we only need pushing to Docker Hub and haven't investigated/tested other CPU architectures for the image yet. For now this is just to allow us to resolve grafana/docker-otel-lgtm#837. |
|
Okidoki 🙂 Since both fields have the same name, I think it would be fine to still have that in the "old" action 😄 |
Consume changes from grafana/shared-workflows#1471. Signed-off-by: Martin Costello <[email protected]>
Consume changes from grafana/shared-workflows#1471. Signed-off-by: Martin Costello <[email protected]>
Allow custom labels to be added to container images.