Skip to content

Conversation

@krishnamd-jkp
Copy link
Contributor

No description provided.

@krishnamd-jkp krishnamd-jkp requested review from a team as code owners December 2, 2025 09:08
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @krishnamd-jkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle bug where an empty filter string was inadvertently being sent in HTTP list object requests, which could lead to unexpected or erroneous behavior from the API. The core change introduces a safeguard to omit the filter parameter entirely if it's empty. To ensure the robustness of this fix and prevent regressions, a dedicated integration test case has been added to verify that listing objects without any filter functions correctly and returns all expected results.

Highlights

  • HTTP Request Filtering: Implemented a conditional check to prevent an empty filter string from being passed in HTTP list object requests, resolving potential issues with the underlying API.
  • Integration Testing: Added a new integration test case specifically to validate the behavior of listing objects when no filter is provided, ensuring the fix works as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where an empty filter string was being sent in a list objects request, which is not supported by the backend API. The fix correctly adds a check to only apply the filter if the string is not empty. This is a clean and effective solution. The addition of a new integration test case for a query without a filter is a great improvement, as it verifies the fix and increases test coverage. The changes are correct and enhance the robustness of the client.

@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2025
@krishnamd-jkp krishnamd-jkp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2025
@krishnamd-jkp krishnamd-jkp merged commit 377eb13 into googleapis:main Dec 2, 2025
9 of 10 checks passed
krishnamd-jkp added a commit that referenced this pull request Dec 5, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.7.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d
<details><summary>storage: 1.58.0</summary>

##
[1.58.0](storage/v1.57.2...storage/v1.58.0)
(2025-12-03)

### Features

* add object contexts in Go GCS SDK (#13390)
([079c4d9](079c4d96))

* calculate crc32c by default and pass checksum in trailing and
per-chunk request (#13205)
([2ab1c77](2ab1c778))

* add support for partial success in ListBuckets (#13320)
([d91e47f](d91e47f2))

### Bug Fixes

* omit empty filter in http list object request (#13434)
([377eb13](377eb13b))

</details>

---------

Co-authored-by: Priti Chattopadhyay <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
krishnamd-jkp added a commit to krishnamd-jkp/google-cloud-go that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants