-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: omit empty filter in http list object request #13434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @krishnamd-jkp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a subtle bug where an empty filter string was inadvertently being sent in HTTP list object requests, which could lead to unexpected or erroneous behavior from the API. The core change introduces a safeguard to omit the filter parameter entirely if it's empty. To ensure the robustness of this fix and prevent regressions, a dedicated integration test case has been added to verify that listing objects without any filter functions correctly and returns all expected results. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug where an empty filter string was being sent in a list objects request, which is not supported by the backend API. The fix correctly adds a check to only apply the filter if the string is not empty. This is a clean and effective solution. The addition of a new integration test case for a query without a filter is a great improvement, as it verifies the fix and increases test coverage. The changes are correct and enhance the robustness of the client.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d <details><summary>storage: 1.58.0</summary> ## [1.58.0](storage/v1.57.2...storage/v1.58.0) (2025-12-03) ### Features * add object contexts in Go GCS SDK (#13390) ([079c4d9](079c4d96)) * calculate crc32c by default and pass checksum in trailing and per-chunk request (#13205) ([2ab1c77](2ab1c778)) * add support for partial success in ListBuckets (#13320) ([d91e47f](d91e47f2)) ### Bug Fixes * omit empty filter in http list object request (#13434) ([377eb13](377eb13b)) </details> --------- Co-authored-by: Priti Chattopadhyay <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.