feat(storage): add support for partial success in ListBuckets

[cpriti-os]

This change adds support for the returnPartialSuccess parameter in ListBuckets calls for both JSON and gRPC client.

When this option is enabled by setting ReturnPartialSuccess = true on the BucketIterator, the GCS API will return a list of reachable buckets even if some are temporarily unavailable. The resource names of any unreachable buckets are returned in a new Unreachable field in the ListBucketsResponse

Integration and unit tests added.

[gemini-code-assist]

Summary of Changes

Hello @cpriti-os, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ListBuckets functionality by introducing a ReturnPartialSuccess option. When enabled, this feature allows the Google Cloud Storage API to return a list of accessible buckets alongside a separate list of any buckets that were unreachable during the operation, providing more robust error handling and user feedback for bucket listing operations.

Highlights

• Partial Success for ListBuckets: Introduced the ReturnPartialSuccess option for ListBuckets calls, allowing the API to return reachable buckets even if some are temporarily unavailable.
• Unreachable Buckets Reporting: Added a new Unreachable field to the ListBucketsResponse and a corresponding Unreachable() method to the BucketIterator to expose the names of any buckets that could not be reached.
• Client-side Implementation: Updated http_client.go to correctly send the returnPartialSuccess query parameter and parse the unreachable field from the JSON API response.
• Comprehensive Testing: Included new unit and integration tests to ensure the correct functionality of the partial success feature and the reporting of unreachable buckets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for returnPartialSuccess when listing buckets, which is a valuable feature. The changes are well-structured, and I appreciate the inclusion of both unit and integration tests. I've found one potential bug related to handling paginated responses with unreachable buckets, where the list of unreachable buckets might be overwritten. I've also left a minor suggestion to simplify the code in the new integration test. Overall, great work on this feature.

[krishnamd-jkp]

Seems like the build is failing because the underlying apiary is not updated yet with new fields. Are you planning to update it?