Skip to content

Fix parsing arcconf physical devices with more than 2 subsections #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glensc merged 1 commit into from
Nov 21, 2016
Merged

Fix parsing arcconf physical devices with more than 2 subsections #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/App/Monitoring/Plugin/CheckRaid/Plugins/arcconf.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,14 @@ sub process_physical_device_information {
my (@pd, $cs, $s);
while (my($ch, $channel_data) = each %$data) {
while (my($pd, $d) = each %$channel_data) {
# FIXME: fallback to 'Device Phy Information' due parser bug
$cs = $d->{_} || $d->{'Device Phy Information'};
# Due to parser bugs not resetting the subsection, flatten all the
# subsections into a single Hash
$cs = {};
foreach my $subsection (values %$d) {
foreach my $key (keys %$subsection) {
$cs->{$key} = $subsection->{$key};
}
}

# FIXME: this should be skipped in check process, not here
if ($pd eq '') {
Expand Down