Fix parsing arcconf physical devices with more than 2 subsections #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A combination of arcconf 2.02 and an Adaptec 8805 produces a third subsection called 'Runtime Error Counters' which breaks the workaround for the subsection hash key not being reset
Owner
|
the parser should be fixed, as it's not the only place with the workaround. and you are missing GETSTATUS output. i can not add the output to testsuite. please attach it. please read CONTRIBUTING.md |
glensc
added a commit
that referenced
this pull request
Nov 21, 2016
glensc
added a commit
that referenced
this pull request
Nov 21, 2016
Contributor
Author
|
GETSTATUS output attached... |
glensc
added a commit
that referenced
this pull request
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combination of arcconf 2.02 and an Adaptec 8805 produces a third
subsection under each physical device called 'Runtime Error Counters' which breaks the workaround
for the subsection hash key not being reset
Arcconf output attached, I'll also provide a patch sometime soon that takes into account the medium errors etc in this section for alerting as well
arcconf.txt