Add Hebrew translations and automated preview deployment workflows #1167
Conversation
- Add Hebrew translations for GitHub cheat sheets - Add submodule vs subtree cheat sheet in Hebrew - Add subversion migration guide in Hebrew - Add AGENTS.md documentation - Update index.html to include new resources 💘 Generated with Crush Assisted-by: Claude Sonnet 4.5 via Crush <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds Hebrew translations for three GitHub training resources and introduces comprehensive AGENTS.md documentation for AI agents working with the repository.
- Adds Hebrew (עברית) translations for Git cheat sheet, subversion migration guide, and submodule vs subtree guide
- Creates detailed AGENTS.md documentation covering project structure, development workflow, and best practices
- Updates index.html with links to new Hebrew translations in appropriate sections
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| index.html | Adds Hebrew translation links in Git Cheat Sheets, SVN migration, and Submodules vs. Subtrees sections |
| downloads/he/github-git-cheat-sheet.md | Hebrew translation of Git cheat sheet with proper RTL formatting |
| downloads/he/subversion-migration.md | Hebrew translation of SVN to Git migration guide with RTL support |
| downloads/he/submodule-vs-subtree-cheat-sheet.md | Hebrew translation of submodules vs subtrees guide with RTL directives |
| AGENTS.md | Comprehensive documentation guide for AI agents, covering project structure, commands, workflows, and conventions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| redirect_to: false | ||
| title: <div dir="rtl">דף תזכורת Git של GitHub</div> | ||
| byline: <p dir="rtl">Git היא מערכת קוד פתוח לניהול גרסאות מבוזרת שמאפשרת את הפעילות של GitHub על המחשב שלכם. דף תזכורת זה מרכז את פקודות שורת הפקודה הנפוצות של Git לעיון מהיר.</p> | ||
| leadingpath: ../../../ |
There was a problem hiding this comment.
The leadingpath should be ../../ (two levels up) instead of ../../../ (three levels up). This file is located at downloads/he/github-git-cheat-sheet.md, which is 2 directory levels deep from the root, so it needs to go up 2 levels to reach the root where assets are located. The Spanish translation at the same depth (downloads/es_ES/) correctly uses ../../.
| leadingpath: ../../../ | |
| leadingpath: ../../ |
| redirect_to: false | ||
| title: <div dir="rtl">טיפול בתלויות עם Submodules ו-Subtrees</div> | ||
| byline: <p dir="rtl">Submodules ו-subtrees הם כלי Git שמאפשרים לכלול תתי-פרויקטים כתת-תיקייה בתוך פרויקט. המימוש של כל אחד מהם שונה מאוד.</p> | ||
| leadingpath: ../../../ |
There was a problem hiding this comment.
The leadingpath should be ../../ (two levels up) instead of ../../../ (three levels up). This file is located at downloads/he/submodule-vs-subtree-cheat-sheet.md, which is 2 directory levels deep from the root. Other translations at the same depth (e.g., downloads/es_ES/) correctly use ../../.
| leadingpath: ../../../ | |
| leadingpath: ../../ |
| redirect_to: false | ||
| title: <div dir="rtl">מעבר מ-Subversion ל-Git</div> | ||
| byline: <p dir="rtl">כשעוברים מ-Subversion ל-Git, יש אוצר מילים וערכת פקודות ללמוד, בנוסף ליכולות החדשות שרק Git מאפשר. דף תזכורת זה נועד לעזור לכם במעבר בין טכנולוגיית Subversion הקלאסית לשימוש המודרני ב-Git עם פלטפורמת השיתוף GitHub.</p> | ||
| leadingpath: ../../../ |
There was a problem hiding this comment.
The leadingpath should be ../../ (two levels up) instead of ../../../ (three levels up). This file is located at downloads/he/subversion-migration.md, which is 2 directory levels deep from the root. Other translations at the same depth (e.g., downloads/es_ES/) correctly use ../../.
| leadingpath: ../../../ | |
| leadingpath: ../../ |
There was a problem hiding this comment.
compare with other files, all of them are using this path... @copilot
Enables automatic preview deployments for PRs from forks, streamlining translation review and content editing approval.
Features:
- Builds Jekyll site for fork PRs only (excludes internal PRs)
- Deploys to fork's GitHub Pages under pr-{number}/ directory
- Auto-creates gh-pages branch if needed
- Posts preview URL as PR comment
- Uses fine-grained PAT with minimal permissions (Contents + Pages)
Setup guide included for fork owners.
💖 Generated with Crush
Assisted-by: Claude Sonnet 4.5 via Crush <[email protected]>
Complements existing PR preview with automatic fork-based previews.
Two-stage review process:
1. Fork Preview (fork-preview.yml) - Runs automatically on push to fork branches
- No approval needed
- Uses GITHUB_TOKEN (no PAT required)
- URL: https://{fork-owner}.github.io/training-kit/preview/{branch}/
- Best for: self-review and team discussion
2. PR Preview (pr-preview.yml) - Runs on PR creation (existing workflow)
- Requires maintainer approval
- Uses fine-grained PAT
- URL: https://{fork-owner}.github.io/training-kit/pr-{number}/
- Best for: maintainer review
Benefits:
- Contributors can iterate quickly without waiting for approval
- Translation teams can review before formal PR submission
- Maintainers review already-vetted content
- Both workflows optional and complementary
💖 Generated with Crush
Assisted-by: Claude Sonnet 4.5 via Crush <[email protected]>
wildcard
changed the title
|
✅ Baseurl issue fixed! The preview URLs now correctly include the full path for assets and links. Working preview: https://wildcard.github.io/training-kit/preview/test-preview-fix/ All links and CSS/assets now load properly with the corrected baseurl that includes the preview directory path. |
🎉 Complete Preview Deployment System + Hebrew TranslationThis PR now includes two major contributions: 1. 📚 Hebrew Translation (עברית)Complete Hebrew translations of core documentation: Git Cheat Sheet: SVN Migration Guide: Submodules vs Subtrees: All translations include:
2. 🚀 Automated Preview Deployment WorkflowsThis PR demonstrates the value of the new workflow system - you can review the Hebrew translations live before merging! Two-Stage Preview System:Stage 1: Fork Preview (Automatic)
Stage 2: PR Preview (Maintainer-Approved)
Benefits Demonstrated:
📋 Review ChecklistHebrew Translation:
Preview Workflows:
🔄 Gradual Review Process in ActionThis PR followed the recommended workflow:
📖 DocumentationSetup guides included:
The preview system is designed to streamline translation reviews and make it easier for content editors to contribute quality translations like this Hebrew addition. |
wildcard
changed the title
Fixed technical terminology, improved natural Hebrew phrasing, and ensured command-line examples follow international standards. Key improvements: - Replaced awkward transliterations with natural Hebrew + English refs - Fixed technical inaccuracies (staging area vs version control) - Standardized glossary format: Hebrew term (English reference) - Reverted all command-line args to English for universal clarity - Improved warning severity to match original tone - Removed nonsensical translations and financial terminology 26 corrections across 3 Hebrew translation files to align with professional technical documentation standards. 💘 Generated with Crush Assisted-by: Claude Sonnet 4.5 via Crush <[email protected]>
Hebrew Translation Quality ImprovementsAs part of this PR, I've reviewed and improved the Hebrew translations for technical accuracy and natural Israeli Hebrew dialect. Changes Made (26 corrections across 3 files)Translation Quality Fixes:
Command-Line Standards:
Translation Principles Applied
The Hebrew documentation now aligns with professional technical documentation standards while maintaining accessibility for Hebrew-speaking developers. Files modified:
Commit: b1c2a52 |
Following Hebrew translation best practices, add English reference to 'מאגר' (repository) when first introduced in section titles and opening sentences for clarity.
1 participant
Summary
Adds two complementary preview deployment workflows to streamline translation review and content approval:
1. Fork Preview Workflow (New)
GITHUB_TOKEN(no PAT required)https://{fork-owner}.github.io/training-kit/preview/{branch}/2. PR Preview Workflow (Existing, Enhanced)
https://{fork-owner}.github.io/training-kit/pr-{number}/Gradual Review Process
Step 1: Development & Self-Review (Fork Preview)
Step 2: Team Discussion (Fork Preview)
Step 3: PR Submission & Final Review (PR Preview)
Benefits
For Contributors:
For Translation Teams:
For Maintainers:
Setup Required
Fork Preview: Just enable GitHub Pages (one-time)
PR Preview (optional): Additionally create fine-grained PAT
See detailed setup guides in:
.github/workflows/FORK_PREVIEW_SETUP.md.github/workflows/PR_PREVIEW_SETUP.md.github/workflows/README.mdTesting
Fork preview tested successfully:
Example: https://wildcard.github.io/training-kit/preview/test-pr-preview/