Skip to content

Remove any references to Python 3.8 #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martindurant merged 3 commits into from
Jul 14, 2025
Merged

Remove any references to Python 3.8 #1888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1aa8d3f
Remove any references to Python 3.8
DimitriPapadopoulos Jul 9, 2025
72f9e22
Get rid of unused `typecheck` CI job
DimitriPapadopoulos Jul 14, 2025
44b37ec
Remove reference to a specific version fo Python
DimitriPapadopoulos Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup conda
uses: conda-incubator/setup-miniconda@v3
with:
environment-file: ci/environment-py38.yml
environment-file: ci/environment-py39.yml
python-version: ${{ matrix.PY }}

- name: Run Tests
Expand Down
0 ci/environment-py38.yml → ci/environment-py39.yml
View file
Open in desktop
Copy link
Member

@martindurant martindurant Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine, we rename it. This didn't actually change anything, though!

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, py38 feels definitely wrong, py39 is less wrong. Perhaps rename to py, since this file is not directly related to the minimal Python version?

Copy link
Member

@martindurant martindurant Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the python version is overidden in the GHA

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's why keeping a version of Python in this file name is misleading.

Copy link
Member

@martindurant martindurant Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, so let's change it to something that works!

Copy link
Contributor Author

@DimitriPapadopoulos DimitriPapadopoulos Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps linux, as it's the name of the associated CI job.

filesystem_spec/.github/workflows/main.yaml

Lines 9 to 12 in b5f9391

jobs:
linux:
name: ${{ matrix.PY }}-pytest
runs-on: ubuntu-24.04

Copy link
Member

@martindurant martindurant Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the name is *-pytest , the dictionary key doesn't seem to matter :)
But yes, linux would be fine.

File renamed without changes.
2 changes: 1 addition & 1 deletion ci/environment-typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ channels:
dependencies:
- mypy=1.4.1
- pyarrow
- python=3.8
- python=3.9
- pip
- pip:
- types-paramiko
Expand Down
Loading