Remove any references to Python 3.8 #1888
Conversation
|
Indeed 3.8 is EOL, and I support dropping any mention to it. However, this PR does not drop support for it, but changes the installed python version for one of the CI checking runs - a run which is not currently invoked at all. |
|
(the changelog suggests 3.8 support was dropped in code in 2025.3.2) |
|
Then how about removing file I came across this file while grep'ping for I wrote "Drop support" because I see this issue as a left-over from the PR that did drop support for 3.8. I will change the title. |
DimitriPapadopoulos
force-pushed
the
python_3.8
branch
from
9944832 to
fca83e9
Compare
DimitriPapadopoulos
force-pushed
the
python_3.8
branch
from
fca83e9 to
1aa8d3f
Compare
DimitriPapadopoulos
changed the title
There was a problem hiding this comment.
OK, fine, we rename it. This didn't actually change anything, though!
There was a problem hiding this comment.
Well, py38 feels definitely wrong, py39 is less wrong. Perhaps rename to py, since this file is not directly related to the minimal Python version?
There was a problem hiding this comment.
The value of the python version is overidden in the GHA
There was a problem hiding this comment.
Yes, that's why keeping a version of Python in this file name is misleading.
There was a problem hiding this comment.
Right, so let's change it to something that works!
There was a problem hiding this comment.
Perhaps linux, as it's the name of the associated CI job.
filesystem_spec/.github/workflows/main.yaml
Lines 9 to 12 in b5f9391
There was a problem hiding this comment.
Actually, the name is *-pytest , the dictionary key doesn't seem to matter :)
But yes, linux would be fine.
|
Feel free to remove ci/environment-typecheck.yml |
Use the name of the CI job that uses the file instead.
|
All good! |
2 participants
No description provided.