[feature] enable http2 support #691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielcsapo
force-pushed
the
support-http2
branch
from
71fcb2e to
773cb62
Compare
Pull Request Test Coverage Report for Build 472
💛 - Coveralls |
| }, | ||
| "dependencies": { | ||
| "methods": "1.1.2", | ||
| "spdy": "^4.0.2", |
Collaborator
There was a problem hiding this comment.
Shouldn't this go in dev dependencies instead?
Contributor
There was a problem hiding this comment.
We can do without spdy since Node.js support http2 natively now.
I have taken the liberty to create PR #793 which builds on this.
Merged
Collaborator
|
Closed via #793 and released in v6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A lot of the footwork has been done in #494. This continues that work.