Support http2. #494
Support http2. #494
Conversation
|
Any updates on this? I'm looking to upgrade some existing tests that use |
|
/cc @rimiti friendly ping, what is blocker to support this? We need this for |
|
any update on this? |
lamweili
left a comment
lamweili
left a comment
There was a problem hiding this comment.
To update the dependencies to not point to git/forked repositories.
| "dependencies": { | ||
| "methods": "~1.1.2", | ||
| "superagent": "3.8.2" | ||
| "superagent": "git+https://github.com/visionmedia/superagent.git" |
There was a problem hiding this comment.
| "superagent": "git+https://github.com/visionmedia/superagent.git" | |
| "superagent": "^8.0.0" |
Maybe point back to superagent@^8.0.0 now that forwardemail/superagent#1414 has been merged.
PS: superagent@^8.0.0 is in the master branch package.json at the time of writing.
| "eslint-config-airbnb-base": "^12.1.0", | ||
| "eslint-plugin-import": "2.11.0", | ||
| "express": "^4.16.3", | ||
| "express": "git+https://github.com/sogaani/express.git#initial-support-http2", |
There was a problem hiding this comment.
| "express": "git+https://github.com/sogaani/express.git#initial-support-http2", | |
| "express": "^4.18.1", |
Similar to forwardemail/superagent#1414 (comment), it would be good to depend directly on express@^4.18.1.
PS: express@^4.18.1 is in the master branch package.json at the time of writing.
|
This PR looks promising but would need @sogaani to resolve the conflicts or rebase. |
|
Closed via #793 and released in v6.3.0 |
6 participants
Hi
This PR adds http2 support to add http2 tests on express.
This PR depend on forwardemail/superagent#1399.