Skip to content

fix(package_info_plus): incorrect install time returned on macOS when app sandbox disabled #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbuberen merged 1 commit into from
Aug 10, 2025
Merged

fix(package_info_plus): incorrect install time returned on macOS when app sandbox disabled #3638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/package_info_plus/package_info_plus/lib/package_info_plus.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ class PackageInfo {
/// The time when the application was installed.
///
/// - On Android, returns `PackageManager.firstInstallTime`
/// - On iOS and macOS, return the creation date of the app default `NSDocumentDirectory`
/// - On iOS, return the creation date of the app default `NSDocumentDirectory`
/// - On macOS, if the app is running in sandbox, return the creation date of the app default `NSDocumentDirectory`;
/// If the app is not running in sandbox, return the last modified date of the app main bundle
/// - On Windows and Linux, returns the creation date of the app executable.
/// If the creation date is not available, returns the last modified date of the app executable.
/// If the last modified date is not available, returns `null`.
Expand Down
17 changes: 13 additions & 4 deletions ...ge_info_plus/macos/package_info_plus/Sources/package_info_plus/FPPPackageInfoPlusPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
- (void)handleMethodCall:(FlutterMethodCall *)call
result:(FlutterResult)result {
if ([call.method isEqualToString:@"getAll"]) {
NSDate *installDate = [self getInstallDate];
NSDate *updateDate = [self getUpdateDate];
NSString *installDateStr = [self getTimeMillisStringFromDate:[self getInstallDate]];
NSString *updateDateStr = [self getTimeMillisStringFromDate:[self getUpdateDate]];

result(@{
@"appName" : [[NSBundle mainBundle]
Expand All @@ -33,15 +33,19 @@ - (void)handleMethodCall:(FlutterMethodCall *)call
objectForInfoDictionaryKey:@"CFBundleVersion"]
?: [NSNull null],
@"installerStore" : [NSNull null],
@"installTime" : [self getTimeMillisStringFromDate:installDate] ?: [NSNull null],
@"updateTime" : [self getTimeMillisStringFromDate:updateDate] ?: [NSNull null]
@"installTime" : installDateStr ?: updateDateStr ?: [NSNull null],
@"updateTime" : updateDateStr ?: [NSNull null]
});
} else {
result(FlutterMethodNotImplemented);
}
}

- (NSDate *)getInstallDate {
if (![self isRunningInSandbox]) {
return nil;
}

NSURL* urlToDocumentsFolder = [[[NSFileManager defaultManager] URLsForDirectory:NSDocumentDirectory inDomains:NSUserDomainMask] lastObject];
__autoreleasing NSError *error;
NSDictionary *attributes = [[NSFileManager defaultManager] attributesOfItemAtPath:urlToDocumentsFolder.path error:&error];
Expand Down Expand Up @@ -74,4 +78,9 @@ - (NSString *)getTimeMillisStringFromDate:(NSDate *)date {
return [timeMillis stringValue];
}

- (BOOL)isRunningInSandbox {
NSString *sandboxContainerId = [[[NSProcessInfo processInfo] environment] objectForKey:@"APP_SANDBOX_CONTAINER_ID"];
return sandboxContainerId != nil;
}

@end
4 changes: 3 additions & 1 deletion packages/package_info_plus/package_info_plus_platform_interface/lib/package_info_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ class PackageInfoData {
/// The time when the application was installed.
///
/// - On Android, returns `PackageManager.firstInstallTime`
/// - On iOS and macOS, return the creation date of the app default `NSDocumentDirectory`
/// - On iOS, return the creation date of the app default `NSDocumentDirectory`
/// - On macOS, if the app is running in sandbox, return the creation date of the app default `NSDocumentDirectory`;
/// If the app is not running in sandbox, return the last modified date of the app main bundle
/// - On Windows and Linux, returns the creation date of the app executable.
/// If the creation date is not available, returns the last modified date of the app executable.
/// If the last modified date is not available, returns `null`.
Expand Down