fix(package_info_plus): incorrect install time returned on macOS when app sandbox disabled #3638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, this plugin get the
installTimeby retrieving the creation date ofNSDocumentDirectoryon macOS. However, the path ofNSDocumentDirectoryvaries on whether the app has the app sandbox enabled.NSDocumentDirectorypath return value when App Sandbox:~/Library/Containers/<BundleId>/Data/Documents~/DocumentsThis is leading to 2 problems when App Sandbox Disabled:
~/Documentscan't be used as app first installation time.This PR fixes the issue by returning the main bundle's last modified date as the
installTimewhen the app is not sandboxed. Since currently there's no reliable way to get the first install time when sandbox disabled, the modified date is used as an approximate fallback.Related Issues
Fixes #3636, #3434 (comment)
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).