Skip to content

format: fix f precision when exponent > 0 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericlagergren merged 1 commit into from
Dec 6, 2019
Merged

format: fix f precision when exponent > 0 #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion big.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ func (x *Big) Format(s fmt.State, c rune) {
} else {
// %f's precision means "number of digits after the radix"
if x.exp > 0 {
f.prec += x.Precision()
f.prec += (x.exp + x.Precision())
} else {
if adj := x.exp + x.Precision(); adj > -f.prec {
f.prec += adj
Expand Down
12 changes: 12 additions & 0 deletions big_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package decimal_test

import (
"fmt"
"math"
"math/big"
"math/rand"
Expand Down Expand Up @@ -268,3 +269,14 @@ got : %g
}

func isSpecial(f float64) bool { return math.IsInf(f, 0) || math.IsNaN(f) }

func TestBig_Format(t *testing.T) {
x, _ := new(decimal.Big).SetString("200.0")
x.Reduce()

y := fmt.Sprintf("%.2f", x)

if y != "200.00" {
t.Fatalf("want 200.00 but had %s", y)
}
}