format: fix f precision when exponent > 0
#148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would take only precision without also considering the exponent, meaning you would have scenarios like 200 being formatted with `%.2f` as just `200` as `x.exp` would be 2, and `x.Precision()` would be 1.
Owner
|
hi, just letting you know I did see this issue. I really appreciate the PR and I plan on merging it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋Hi @ericlagergren — we've noticed a small edge case in the
fformat flag. It looks like this will be also fixed in #144 but I figured I would report it anyway and propose a small change for the existing version if that one is still WIP.Previously we would take only precision without also considering the
exponent, meaning you would have scenarios like 200 being formatted with
%.2fas just200asx.expwould be 2, andx.Precision()would be 1.