Skip to content

[9.0] Use elastic apm connector to replace other apm components #7172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 4, 2025
Merged

[9.0] Use elastic apm connector to replace other apm components #7172

merged 11 commits into from
Mar 4, 2025

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Mar 4, 2025 •
edited
Loading

What does this PR do?

The PR replaces lsminterval processor and signaltometrics connector with the newly introduced elasticapm connector which wraps both the processor and the connector with the required APM configurations.

In addition, the PR also removes aggregation for metrics pipeline as required by elastic/opentelemetry-collector-components#390

The PR is same as #6937 but for 9.0 branch since the upgrade of otel components to version 0.120.0 has been merged to 9.0 already however, the main PR is still pending.

Why is it important?

To centralize all APM components and configurations a new connector component called elasticapmconnector was recently introduced. The component encapsulates the signaltometrics connector and the lsminterval connector along with the required configurations for APM.

To handle metrics-only services correctly for the UI.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in ./changelog/fragments using the changelog tool
    - [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@lahsivjar lahsivjar requested a review from a team as a code owner March 4, 2025 11:55
@lahsivjar lahsivjar requested review from andrzej-stencel and swiatekm and removed request for a team March 4, 2025 11:55
@lahsivjar
Copy link
Contributor Author

[For reviewers] I haven't added a changelog file since there are no end-user changes but let me know if I need to add one.

@lahsivjar lahsivjar requested a review from AlexanderWert March 4, 2025 11:56
@lahsivjar lahsivjar force-pushed the elasticapm-connector-9.0 branch from 4508e77 to e0b324e Compare March 4, 2025 12:53
@lahsivjar lahsivjar changed the title Elasticapm connector 9.0 [9.0Use elastic apm connector to replace other apm components Mar 4, 2025
@lahsivjar lahsivjar changed the title [9.0Use elastic apm connector to replace other apm components [9.0] Use elastic apm connector to replace other apm components Mar 4, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 4, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

lahsivjar
lahsivjar commented Mar 4, 2025
View reviewed changes
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@lahsivjar lahsivjar enabled auto-merge (squash) March 4, 2025 16:14
@lahsivjar lahsivjar merged commit efeb73b into elastic:9.0 Mar 4, 2025
14 checks passed
@lahsivjar lahsivjar deleted the elasticapm-connector-9.0 branch March 4, 2025 20:32
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @lahsivjar

@lahsivjar lahsivjar mentioned this pull request Mar 4, 2025
Closed
@swiatekm swiatekm added the backport-8.18 Automated backport to the 8.18 branch label Mar 18, 2025
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
@lahsivjar @mergify
[9.0] Use elastic apm connector to replace other apm components (#7172)
1f3a1fe 
(cherry picked from commit efeb73b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
@mergify mergify bot mentioned this pull request Mar 18, 2025
Merged
5 tasks
swiatekm pushed a commit that referenced this pull request Mar 18, 2025
@lahsivjar @swiatekm
[9.0] Use elastic apm connector to replace other apm components (#7172)
0fcf60d 
(cherry picked from commit efeb73b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md
swiatekm pushed a commit that referenced this pull request Mar 18, 2025
@mergify @lahsivjar
[9.0] Use elastic apm connector to replace other apm components (#7172)…
bcd3fcc 
… (#7452)

(cherry picked from commit efeb73b)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
#	internal/pkg/otel/README.md

Co-authored-by: Vishal Raj <[email protected]>
@andrzej-stencel andrzej-stencel mentioned this pull request Apr 7, 2025
Merged
8 tasks
khushijain21
khushijain21 reviewed Apr 22, 2025
View reviewed changes
go.mod
@@ -23,16 +23,15 @@ require (
github.com/elastic/go-sysinfo v1.15.1
github.com/elastic/go-ucfg v0.8.8
github.com/elastic/mock-es v0.0.0-20241101195702-0a41fa3d30d9
github.com/elastic/opentelemetry-collector-components/connector/signaltometricsconnector v0.3.0
github.com/elastic/opentelemetry-collector-components/connector/elasticapmconnector v0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason this was not changed to v0.2.1? like it was changed on main branch?

https://github.com/elastic/elastic-agent/blob/main/go.mod#L28

Copy link
Contributor Author

@lahsivjar lahsivjar Apr 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably missed since the PR has been open for a long time, however, the main is on v0.121.0 whereas 9.0 is on v0.120.0 for upstream components (at least when the PR was created). The update to the apm connector for v0.2.1 was mainly to allow upgrading to the newer version so it is not critical to get this in. Are you facing any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushijain21 khushijain21 khushijain21 left review comments

@swiatekm swiatekm swiatekm approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@AlexanderWert AlexanderWert Awaiting requested review from AlexanderWert

Assignees

@lahsivjar lahsivjar

Labels
backport-8.18 Automated backport to the 8.18 branch backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lahsivjar @elasticmachine @khushijain21 @swiatekm @pierrehilbert