-
Notifications
You must be signed in to change notification settings - Fork 169
Use elastic apm connector to replace other apm components #6937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
PR #7050 should fix the blocker |
|
@lahsivjar can you update the conflicts in the PR and then re-request a review? |
@simitt The blocking PR (updating the Also, we have this slack thread with some discussion around this. |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @lahsivjar |
What does this PR do?
The PR replaces
lsminterval
processor andsignaltometrics
connector with the newly introducedelasticapm
connector which wraps both the processor and the connector with the required APM configurations.In addition, the PR also removes aggregation for metrics pipeline as required by elastic/opentelemetry-collector-components#390
Why is it important?
To centralize all APM components and configurations a new connector component called elasticapmconnector was recently introduced. The component encapsulates the signaltometrics connector and the lsminterval connector along with the required configurations for APM.
The PR will be blocked by #6912 and elastic/beats#42748
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself