Skip to content

Use elastic apm connector to replace other apm components #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 8, 2025

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Feb 20, 2025

What does this PR do?

The PR replaces lsminterval processor and signaltometrics connector with the newly introduced elasticapm connector which wraps both the processor and the connector with the required APM configurations.

In addition, the PR also removes aggregation for metrics pipeline as required by elastic/opentelemetry-collector-components#390

Why is it important?

To centralize all APM components and configurations a new connector component called elasticapmconnector was recently introduced. The component encapsulates the signaltometrics connector and the lsminterval connector along with the required configurations for APM.

The PR will be blocked by #6912 and elastic/beats#42748

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@lahsivjar lahsivjar requested a review from a team as a code owner February 20, 2025 10:05
Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Feb 21, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b elasticapm-connector upstream/elasticapm-connector
git merge upstream/main
git push upstream elasticapm-connector

@lahsivjar
Copy link
Contributor Author

PR #7050 should fix the blocker

Copy link

@simitt
Copy link
Contributor

simitt commented Mar 25, 2025

@lahsivjar can you update the conflicts in the PR and then re-request a review?

@lahsivjar
Copy link
Contributor Author

@simitt The blocking PR (updating the main branch to use v0.120.0++ for OTel collector) is still not merged so unfortunately, we are still blocked - 8.18 and 9.0 branches already have the changes merged, only main is remaining. #6912 is the blocking PR. So, we won't be able to merge this for now.

Also, we have this slack thread with some discussion around this.

Copy link
Contributor

mergify bot commented Mar 25, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b elasticapm-connector upstream/elasticapm-connector
git merge upstream/main
git push upstream elasticapm-connector

andrzej-stencel
andrzej-stencel previously approved these changes Apr 7, 2025
Copy link
Contributor

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlexanderWert
AlexanderWert previously approved these changes Apr 7, 2025
rogercoll
rogercoll previously approved these changes Apr 7, 2025
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lahsivjar lahsivjar dismissed stale reviews from rogercoll and AlexanderWert via dec71f9 April 7, 2025 12:00
@lahsivjar lahsivjar enabled auto-merge (squash) April 7, 2025 15:56
Copy link

@lahsivjar lahsivjar merged commit 9a555bc into elastic:main Apr 8, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @lahsivjar

@lahsivjar lahsivjar deleted the elasticapm-connector branch April 8, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elasticapm] Remove service_summary metric for metrics-only services
7 participants