Skip to content

adds notification whenever home location is changed #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2016

Conversation

hamishwillee
Copy link
Contributor

@hamishwillee hamishwillee commented Jul 20, 2016

Now we're updating the home_location from messages we can reasonably add attribute notification. Obviously this won't work before notification messages were added (we probably should add documentation to state that, rather than just saying "notification not supported".

This fixes minor bug in #646

@hamishwillee
Copy link
Contributor Author

@peterbarker @mrpollo Please review and push in.

@mrpollo mrpollo force-pushed the hgw_fix_notifier_home_location_changes branch from 5d4f310 to 9136a60 Compare August 29, 2016 21:13
@mrpollo
Copy link
Member

mrpollo commented Aug 30, 2016

lgtm, 👍

@mrpollo mrpollo merged commit 1e87178 into master Aug 30, 2016
@mrpollo mrpollo deleted the hgw_fix_notifier_home_location_changes branch August 30, 2016 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants