Re-enable bundle archive building in source build #110448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
jkoritzinsky
added
blocked
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
ViktorHofer
approved these changes
Dec 5, 2024
Member
|
Added the arcade update here so we don't need to deal with the net10 bump in latest arcade. |
Member
Member
Author
|
Dang it. I could have sworn that would fix it. I'll grab the binlog and figure it out today. |
This was referenced Dec 6, 2024
Closed
Member
Author
|
Fix available here: dotnet/arcade#15312 |
jkoritzinsky
force-pushed
the
bundle-in-source-build
branch
from
15dd9ef to
15609be
Compare
Member
Author
|
Looks like I got the fix right now if you look at attempt 1 of the source build job. We can't merge it due to prebuilt detection failing due to upgrading the installers package without upgrading arcade, but we know that the fix works now. |
This was referenced Dec 7, 2024
ViktorHofer
force-pushed
the
bundle-in-source-build
branch
from
15609be to
ab48757
Compare
Member
|
Merging as source-build leg passed and that's the only thing that this PR touches. |
Member
|
/ba-g fast merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks dotnet/sdk#45042
Depends on dotnet/arcade#15306 flowing