Don't assume that BaseOS has a value #15312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we can end up building a non-portable build with a portable rid and without specifying a BaseOS value. Handle that in the installer targets logic.
akoeplinger
approved these changes
Dec 6, 2024
Member
|
Thanks. Once this is built we should update just the Microsoft.DotNet.Build.Tasks.Installers package version in your runtime PR since the regular arcade bump will bring in the net10 change. |
Member
Author
|
@akoeplinger I don't think we'll be able to merge with just updating that package (as it will cause prebuilt warnings) but I can give it a shot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we can end up building a non-portable build with a portable rid and without specifying a BaseOS value. Handle that in the installer targets logic.
To double check: