-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Add size update for Shell Popup Overlay after rotation #15866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey there @cat0363! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
The solution I posted last time is not beautiful because the overlay is temporarily drawn in the size Below is the execution result.
With this fix, overlays are no longer drawn at their pre-rotation size. |
|
@samhouts, A stale tag has been added, but has the issue been resolved? |
|
@cat0363 The stale label is just an easy way for us to query PRs that haven't been updated in a while. This isn't resolved to my knowledge because this PR hasn't been merged. Thanks for your patience! |
|
@samhouts , Thank you for your reply despite your busy schedule. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
688e9c1 to
6e09dd6
Compare
# Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
# Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ee8e282 to
712c680
Compare
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
* Added size update for Shell Popup Overlay after rotation # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * Fix resizing on rotation * - fix publicapi # Conflicts: # src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt * - apply copilot suggested change * - Add Tests * - fix test * - make backdrop orange --------- Co-authored-by: Shane Neuville <[email protected]>
…otnet#15866)" This reverts commit 376e6ea.
#32868) This PR addresses the UI test image failures that occurred in the inflight/candidate branch #32841 and includes updates to improve rendering and test stability across platforms. - In ShouldFlyoutTextWrapsInLandscape test case, added the resaved CI snapshot caused by changes from fix PR - #15866 - In FlyoutOverlayResizesOnRotation test cases, disable for android platform, because the Shell FlyoutContent overlaps the navigation bar due to SafeArea during Landscape Orientation, Related issue: #32275 **Test cases:** - ShouldFlyoutTextWrapsInLandscape - NavigationBarShouldRemainHiddenAfterNavigatingBack - FlyoutOverlayResizesOnRotation - VerticalGridCollectionViewLTRToRTLToggleShouldWork - VerticalGridCollectionViewRTLColumnMirroringShouldWork
Description of Change
When the terminal is rotated while the Flyout of Shell is displayed, the size of the overlay does not
change from the size before rotation. In this PR, we will be updating the size of the overlay after
rotation so that the overlay appears as intended.
Override the ViewWillTransitionToSize method to update the Tapoffview's Frame on rotation detection.
This will allow the size of the overlay portion to update on rotation. I needed to override the ViewWillTransitionToSize
method, so I added the definition to PublicAPI.Unshipped.txt.
[src\Controls\src\Core\PublicAPI\net-ios\PublicAPI.Unshipped.txt]
[src\Controls\src\Core\PublicAPI\net-maccatalyst\PublicAPI.Unshipped.txt]
[src\Controls\src\Core\Compatibility\Handlers\Shell\iOS\ShellFlyoutRenderer.cs]
Below is the execution result.
iPhone.14.iOS.16.4.2023-06-26.15-06-51.mp4
Could you please check it? Thank you.
Issues Fixed
Fixes #15173