fix: Resolves issue preventing new MyMLH users from creating questionnaires #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend validation is triggered via page skip, whether successful (will skip) or not (no skip)
houndci-bot
reviewed
Jan 6, 2021
| @@ -29,17 +30,23 @@ def new | |||
| if session["devise.provider_data"] && session["devise.provider_data"]["info"] | |||
| info = session["devise.provider_data"]["info"] | |||
| @skip_my_mlh_fields = true | |||
| if !all_my_mlh_fields_provided? | |||
There was a problem hiding this comment.
Style/NegatedIf: Favor unless over if for negative conditions.
peterkos
approved these changes
Jan 6, 2021
cbaudouinjr
added a commit
that referenced
this pull request
Jan 6, 2021
* fix: Resolves issue preventing new MyMLH users from creating questionnaires (#516) * fix: Resolves issue preventing new MyMLH users from creating questionnaires * refactor: Cleans code * Attempt to pull any # of params from MyMLH frontend validation is triggered via page skip, whether successful (will skip) or not (no skip) * Cange error msg, pet hound Co-authored-by: Peter Kos <[email protected]> * vcs url error now displayed in edit application page (#518) changed from redirect_to to render "edit" on error. redirect_to makes a fresh request which causes the error information to be lost Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: JeremyRudman <[email protected]>
peterkos
added a commit
that referenced
this pull request
Jan 8, 2021
* fix(questionnaire): missing information now in correct place (#443) * fix(questionnair): missing information now in correct place it now displays the correct message "Please read & accept" instead of missing information and the notification is now in the correct place * Update app/assets/javascripts/validate.js * Revert "Update app/assets/javascripts/validate.js" This reverts commit bc54783. Signed-off-by: Peter Kos <[email protected]> Co-authored-by: Peter Kos <[email protected]> * fix: Fixes mobile agreements layout bug Signed-off-by: Peter Kos <[email protected]> * feat: Removes semantic-release (#446) * refactor: Moves CI to develop branch (#449) Co-authored-by: Peter Kos <[email protected]> * build: Merges 2.1.2 into develop * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output Co-authored-by: Jeremy Rudman <[email protected]> Co-authored-by: JeremyRudman <[email protected]> * fix: Shows questionnaires_closed_message on registration * feat: Allows agreements to be fully customizable (#465) * feat: Allows agreements to be fully customizable * fix: Fixes broken migrations * fix: Migrations misname issue * feat: Forces agreement links to open in new tab * Agreement validation detection fixed Signed-off-by: Peter Kos <[email protected]> * refactor: Removes old input hint Co-authored-by: Peter Kos <[email protected]> * fix(hakiri): fixed un-escaped regex for vcs link (#467) * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output * fix(hakiri): added \A \z to regex * fix(questionnaire): fixed hakiri error with vcs link regex * fix(questionnaire): fixed houndci commplaint Co-authored-by: Chris Baudouin, Jr <[email protected]> * fix(hakiri): fix hakiri error with user input in html_safe (#475) Co-authored-by: Peter Kos <[email protected]> * fix: Uninstalls deprecated chromedriver (#484) * fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended (#485) * fixed vcs regex to allow upper case added a extra test to vcs links to test upper case links. also made it so portfolio links ands vcs links are stored in lower case * fixed houndci complaints * lossened username regex and add another test * made regex more pleasing to read * made regex method more readable * checks now does 300 attempts * 2.1.4 <- develop (#519) * fix: Resolves issue preventing new MyMLH users from creating questionnaires (#516) * fix: Resolves issue preventing new MyMLH users from creating questionnaires * refactor: Cleans code * Attempt to pull any # of params from MyMLH frontend validation is triggered via page skip, whether successful (will skip) or not (no skip) * Cange error msg, pet hound Co-authored-by: Peter Kos <[email protected]> * vcs url error now displayed in edit application page (#518) changed from redirect_to to render "edit" on error. redirect_to makes a fresh request which causes the error information to be lost Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: JeremyRudman <[email protected]> Co-authored-by: Chris Baudouin, Jr <[email protected]> Co-authored-by: Jeremy Rudman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if any of the required MyMLH data is null. If true, we display an error that instructs the user to continue manually.
fixes #515
Edit flow:
After you auth via MyMLH, it will attempt to skip the first page, whether the info exists or not, triggering the frontend validation.
If no info is missing, it will skip to page 2 of the questionnaire form.
If info is missing, due to the triggered validation, it will attempt to pull as many fields as possible, and highlight the missing field(s):
