Skip to content

fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 25, 2020
Merged

fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended #485

merged 7 commits into from
Dec 25, 2020

Conversation

JeremyRudman
Copy link
Contributor

@JeremyRudman JeremyRudman commented Dec 22, 2020 •
edited
Loading

  • VCS URLs and portfolio URLs are now stored in lower case
  • The regex for VCS is now case insensitive and the username allows non alphanumeric characters
  • Added two more tests for VCS regex

@JeremyRudman
fixed vcs regex to allow upper case
539a793 
added a extra test to vcs links to test upper case links. also made it
so portfolio links ands vcs links are stored in lower case
houndci-bot
houndci-bot reviewed Dec 22, 2020
View reviewed changes
@peterkos peterkos mentioned this pull request Dec 22, 2020
Merged
@JeremyRudman JeremyRudman self-assigned this Dec 23, 2020
This was linked to issues Dec 23, 2020
should block http in vcs links and add custom error when http is used instead of https and when a invalid github username is entered #473
Open
loosen github regex requirements #476
Closed
@JeremyRudman JeremyRudman removed a link to an issue Dec 23, 2020
should block http in vcs links and add custom error when http is used instead of https and when a invalid github username is entered #473
Open
@peterkos peterkos changed the title fixed vcs regex to allow upper case fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive Dec 25, 2020
@peterkos peterkos added 2.1.3 and removed unplanned labels Dec 25, 2020
peterkos
peterkos previously approved these changes Dec 25, 2020
View reviewed changes
@peterkos peterkos changed the title fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended Dec 25, 2020
@peterkos peterkos self-requested a review December 25, 2020 04:32
@JeremyRudman JeremyRudman merged commit 2726945 into develop Dec 25, 2020
peterkos added a commit that referenced this pull request Dec 25, 2020
@peterkos @JeremyRudman @cbaudouinjr
master <- develop (2.1.3) (#489)
2b14f72 
* fix(questionnaire): missing information now in correct place (#443)

* fix(questionnair): missing information now in correct place

it now displays the correct message "Please read & accept" instead of
missing information and the notification is now in the correct place

* Update app/assets/javascripts/validate.js

* Revert "Update app/assets/javascripts/validate.js"

This reverts commit bc54783.

Signed-off-by: Peter Kos <[email protected]>

Co-authored-by: Peter Kos <[email protected]>

* fix: Fixes mobile agreements layout bug

Signed-off-by: Peter Kos <[email protected]>

* feat: Removes semantic-release (#446)

* refactor: Moves CI to develop branch (#449)

Co-authored-by: Peter Kos <[email protected]>

* build: Merges 2.1.2 into develop

* fix(hakiri): corrected unescaped model attribute

* fix(hakiri): added html_safe to show proper output

Co-authored-by: Jeremy Rudman <[email protected]>
Co-authored-by: JeremyRudman <[email protected]>

* fix: Shows questionnaires_closed_message on registration

* feat: Allows agreements to be fully customizable (#465)

* feat: Allows agreements to be fully customizable

* fix: Fixes broken migrations

* fix: Migrations misname issue

* feat: Forces agreement links to open in new tab

* Agreement validation detection fixed

Signed-off-by: Peter Kos <[email protected]>

* refactor: Removes old input hint

Co-authored-by: Peter Kos <[email protected]>

* fix(hakiri): fixed un-escaped regex for vcs link (#467)

* fix(hakiri): corrected unescaped model attribute

* fix(hakiri): added html_safe to show proper output

* fix(hakiri): added \A \z to regex

* fix(questionnaire): fixed hakiri error with vcs link regex

* fix(questionnaire): fixed houndci commplaint

Co-authored-by: Chris Baudouin, Jr <[email protected]>

* fix(hakiri): fix hakiri error with user input in html_safe (#475)

Co-authored-by: Peter Kos <[email protected]>

* fix: Uninstalls deprecated chromedriver (#484)

* fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended (#485)

* fixed vcs regex to allow upper case

added a extra test to vcs links to test upper case links. also made it
so portfolio links ands vcs links are stored in lower case

* fixed houndci complaints

* lossened username regex and add another test

* made regex more pleasing to read

* made regex method more readable

* checks now does 300 attempts

Co-authored-by: JeremyRudman <[email protected]>
Co-authored-by: Chris Baudouin, Jr <[email protected]>
Co-authored-by: Jeremy Rudman <[email protected]>
@peterkos peterkos mentioned this pull request Jan 6, 2021
Merged
peterkos added a commit that referenced this pull request Jan 8, 2021
@peterkos @JeremyRudman @cbaudouinjr
master <- develop (2.1.4) (#520)
4fa6f6e 
* fix(questionnaire): missing information now in correct place (#443)

* fix(questionnair): missing information now in correct place

it now displays the correct message "Please read & accept" instead of
missing information and the notification is now in the correct place

* Update app/assets/javascripts/validate.js

* Revert "Update app/assets/javascripts/validate.js"

This reverts commit bc54783.

Signed-off-by: Peter Kos <[email protected]>

Co-authored-by: Peter Kos <[email protected]>

* fix: Fixes mobile agreements layout bug

Signed-off-by: Peter Kos <[email protected]>

* feat: Removes semantic-release (#446)

* refactor: Moves CI to develop branch (#449)

Co-authored-by: Peter Kos <[email protected]>

* build: Merges 2.1.2 into develop

* fix(hakiri): corrected unescaped model attribute

* fix(hakiri): added html_safe to show proper output

Co-authored-by: Jeremy Rudman <[email protected]>
Co-authored-by: JeremyRudman <[email protected]>

* fix: Shows questionnaires_closed_message on registration

* feat: Allows agreements to be fully customizable (#465)

* feat: Allows agreements to be fully customizable

* fix: Fixes broken migrations

* fix: Migrations misname issue

* feat: Forces agreement links to open in new tab

* Agreement validation detection fixed

Signed-off-by: Peter Kos <[email protected]>

* refactor: Removes old input hint

Co-authored-by: Peter Kos <[email protected]>

* fix(hakiri): fixed un-escaped regex for vcs link (#467)

* fix(hakiri): corrected unescaped model attribute

* fix(hakiri): added html_safe to show proper output

* fix(hakiri): added \A \z to regex

* fix(questionnaire): fixed hakiri error with vcs link regex

* fix(questionnaire): fixed houndci commplaint

Co-authored-by: Chris Baudouin, Jr <[email protected]>

* fix(hakiri): fix hakiri error with user input in html_safe (#475)

Co-authored-by: Peter Kos <[email protected]>

* fix: Uninstalls deprecated chromedriver (#484)

* fix: VCS regex matches all valid usernames for each provider; URLs are now case-insensitive, dokku check extended (#485)

* fixed vcs regex to allow upper case

added a extra test to vcs links to test upper case links. also made it
so portfolio links ands vcs links are stored in lower case

* fixed houndci complaints

* lossened username regex and add another test

* made regex more pleasing to read

* made regex method more readable

* checks now does 300 attempts

* 2.1.4 <- develop (#519)

* fix: Resolves issue preventing new MyMLH users from creating questionnaires (#516)

* fix: Resolves issue preventing new MyMLH users from creating questionnaires

* refactor: Cleans code

* Attempt to pull any # of params from MyMLH

frontend validation is triggered via page skip, whether successful (will skip) or not (no skip)

* Cange error msg, pet hound

Co-authored-by: Peter Kos <[email protected]>

* vcs url error now displayed in edit application page (#518)

changed from redirect_to to render "edit" on error. redirect_to makes
a fresh request which causes the error information to be lost

Co-authored-by: Chris Baudouin, Jr <[email protected]>
Co-authored-by: JeremyRudman <[email protected]>

Co-authored-by: JeremyRudman <[email protected]>
Co-authored-by: Chris Baudouin, Jr <[email protected]>
Co-authored-by: Jeremy Rudman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@peterkos peterkos peterkos approved these changes

Assignees

@JeremyRudman JeremyRudman

Labels
2.1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loosen github regex requirements
3 participants
@JeremyRudman @peterkos @houndci-bot