crdb-release-23.1: Move from StatePause->StateReplicate on heartbeat response when possible #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-bytes-leak tracker: fix byte counter leak in Inflights tracker This change fixes a bug in the Inflights tracker. The reset() method did not zero the bytes counter, which could result in a quota "leak" and delayed or stalled MsgApp sends. The reset() method is used when the replication flow changes state between Probe/Replicate/Snapshot. If reset() is not called at an appropriate moment, when Inflights.Full(), the bytes counter would stay over the budget and stall the flow. Signed-off-by: Pavel Kalinnikov <[email protected]>
…-read raft: paginate the unapplied config changes scan There is a potentially unlimited memory usage spike possible in raft.hup() which reads all unapplied committed entries in order to check that there are no unapplied config changes. This PR paginates this scan so that the spike is limited to MaxCommittedSizePerReady. It also terminates the scan early if a config change has been found. Signed-off-by: Pavel Kalinnikov <[email protected]>
Author
|
Oops, messed up the base/branch picks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports etcd-io#52 on behalf of @tbg.
Move from StatePause->StateReplicate on heartbeat response when possible
See individual commits. Essentially, when a fully caught-up follower was
reported unreachable, it'd transition to
StateProbebut then wouldn'trecover from that via heartbeats (once they resumed).
This caused some issues in CRDB because we rely on the reported status
to reason about the safety of leadership changes, etc.
This PR makes it such that StateProbe resolves on its own: when the
leader hears back from the follower via a heartbeat, it sends an
empty MsgApp, and as response to this moves the follower back into
StateProbe.
Touches cockroachdb/cockroach#104304.
Touches cockroachdb/cockroach#101624.
Signed-off-by: Tobias Grieger [email protected]