tracker: fix byte counter leak in Inflights tracker #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug in the Inflights tracker. The reset() method did not zero the bytes counter, which could result in a quota "leak" and delayed or stalled MsgApp sends. The reset() method is used when the replication flow changes state between Probe/Replicate/Snapshot. If reset() is not called at an appropriate moment, when Inflights.Full(), the bytes counter would stay over the budget and stall the flow. Signed-off-by: Pavel Kalinnikov <[email protected]>
tbg
approved these changes
May 18, 2023
Contributor
Author
|
@ahrtr FYI, this bug shouldn't affect etcd (I assume you don't yet use the MaxInflightBytes option). |
Member
No, etcd doesn't use it at all. |
pav-kv
added a commit
to cockroachdb/raft
that referenced
this pull request
May 19, 2023
…-bytes-leak tracker: fix byte counter leak in Inflights tracker This change fixes a bug in the Inflights tracker. The reset() method did not zero the bytes counter, which could result in a quota "leak" and delayed or stalled MsgApp sends. The reset() method is used when the replication flow changes state between Probe/Replicate/Snapshot. If reset() is not called at an appropriate moment, when Inflights.Full(), the bytes counter would stay over the budget and stall the flow. Signed-off-by: Pavel Kalinnikov <[email protected]>
pav-kv
added a commit
to pav-kv/cockroach
that referenced
this pull request
May 19, 2023
This commit cherry-picks a bug fix for Inflights type into the 23.1 release. The fix is cherry-picked onto a branch parallel to the 23.1 release, in our fork of etcd-io/raft. Release justification: a bug fix in range availability Epic: none Release note: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the Inflights tracker. The reset() method did not zero the bytes counter, which could result in a quota "leak" and delayed or stalled MsgApp sends.
The reset() method is used when the replication flow changes state between Probe/Replicate/Snapshot. If reset() is not called at an appropriate moment, when Inflights.Full(), the bytes counter would stay over the budget and stall the flow.
The test added in this PR failed before, and passes after the change.