Output union values in Detail panel/window #3103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
approved these changes
Jun 18, 2024
Contributor
jameskerr
left a comment
jameskerr
left a comment
There was a problem hiding this comment.
Works for me. I wonder if the logic to should be moved inside the "field" object. Something to consider. But I'll approve this.
This was referenced Jun 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my approach in #3099 passed muster, that made me recall another open, union-centric issue #2938. Sure enough, as shown in the attached video, it seems a similar small change allows these union values to start being output where they weren't before.
Demo.mp4
Fixes #2938