Skip to content

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Jun 17, 2024

Fixes #3098, which has more background.

The video below shows the change having the intended benefit on the original repro shown in #3098, and also with this simpler input file foo.ndjson:

{"_path": "http", "foo": "bar"}
{"_path": 1, "foo": "baz"}
{"_path": true, "foo": "bonk"}
Demo.mp4

@philrz philrz requested a review from jameskerr June 17, 2024 17:39
@philrz philrz self-assigned this Jun 17, 2024
Copy link
Contributor

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that looks right to me.

@philrz philrz merged commit 0dad17d into main Jun 17, 2024
@philrz philrz deleted the unions-in-toZedScript branch June 17, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't "Pivot to Values" after applying fuse

3 participants