Replace luminance-based LED scaling with perceptual balance factors #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach used datasheet luminance values and circuit current calculations to normalize LED brightness. However, this did not produce visually balanced colors in practice. Replace with empirically-derived perceptual balance factors from user survey: - White: 0.84 - Red: 0.692 - Green: 0.421 - Blue: 1.0 (reference) This significantly reduces green output (to 42%) which was previously too bright, and provides better perceptual color balance across all channels. Changes: - Rename ledLuminance_t to ledPerceptualScale_t with float scaling factors - Replace normalizeLuminance() with applyPerceptualScaling() - Update LED_LUMINANCE constant to LED_PERCEPTUAL_SCALE with survey values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach used datasheet luminance values to normalize LED brightness. However, this did not produce visually balanced colors in practice.
Replace with empirically-derived perceptual balance factors from user survey:
The significantly brightens all colors apart from blue.
Changes: