Programmatically-readable color led deck self-test results, add I2C address pin test #1572
+173
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test I2C_ADDRESS pin on Color LED deck connectivity by toggling it LOW/HIGH and verifying the deck MCU reads the correct state via I2C command. Ensures proper signal routing during production testing.
…led test results Enhanced the production self-test for Color LED decks with programmatically-readable test results and integrating LED position verification inside deck self test: - Added deckTest param group with bitmap test results for both decks (bit 0: protocol version, bit 1: LED position, bit 2: I2C address pin) - Replaced pollLedPosition() with verifyLedPosition() that checks LED is mounted on correct PCB side (bottom/top) and fails test on mismatch - Added LED position constants matching deck firmware values (NONE=0x00, BOTTOM=0x01, TOP=0x02) - Removed LED position from log groups (now verified during self test only) - Added comprehensive debug output for all test failures This enables automated production testing to detect hardware assembly errors like LEDs mounted on wrong side.
evoggy
requested changes
Dec 9, 2025
| uint8_t actualPosition = response[1]; | ||
| ctx->ledPosition = actualPosition; | ||
|
|
||
| const char* expectedStr = (expectedPosition == COLORLED_LED_POS_BOTTOM) ? "BOTTOM" : "TOP"; |
Member
There was a problem hiding this comment.
This seems to be only used for debug printing, what about putting it inside an #ifdef DEBUG and inside the if so it's only used if the comparison fails?
Member
Author
There was a problem hiding this comment.
I think this is important info to print, but we only need to (and do) in case of failure, so I moved constructing the string inside the failure case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the production self-test for Color LED decks with programmatically-readable test results and integrating LED position verification inside deck self test:
Requires: