Skip to content

Fix VL53L1 I2C address allocation for Flow+Multi-ranger compatibility #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobbeanton merged 1 commit into from
Nov 28, 2025
Merged

Fix VL53L1 I2C address allocation for Flow+Multi-ranger compatibility #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/drivers/src/vl53l1x.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@
#define VL53L1_get_register_name(a,b)
#endif

// Set the start address 1 step after the VL53L0 dynamic addresses
static int nextI2CAddress = RANGER_DECKS_ADDRESS_START +1;
static int nextI2CAddress = RANGER_DECKS_ADDRESS_START;
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VL53L0 and VL53L1 drivers share the same address space but have separate static nextI2CAddress variables. This creates a potential conflict if both sensor types are initialized simultaneously (e.g., Flow Deck v1 with VL53L0 and Multi-ranger with VL53L1). Consider using a shared address counter or documenting that these drivers cannot be mixed.

Suggested change
static int nextI2CAddress = RANGER_DECKS_ADDRESS_START;
// Shared I2C address counter for VL53L0 and VL53L1 drivers.
// Must be defined in a single source file (e.g., vl53l0x.c or a new shared file):
// int nextI2CAddress = RANGER_DECKS_ADDRESS_START;
extern int nextI2CAddress;

Copilot uses AI. Check for mistakes.


bool vl53l1xInit(VL53L1_Dev_t *pdev, I2C_Dev *I2Cx)
Expand Down