Unconditionally add the testing macro plugin subdirectory to compile actions. #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e actions. Xcode 26.0 beta 5 has isolated this plugin to its own subdirectory and Xcode only passes it to the compiler when building test targets (previous versions had a symlink to make the default path work, but beta 5 removed that symlink). We don't want to make that distinction in our rules, so it's fine to just unconditionally pass it. PiperOrigin-RevId: 795560788 (cherry picked from commit 15da0d2)
adincebic
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Contributor
|
This was already done here, so if we decide to take this, make sure that code is cleaned up first. |
Contributor
Author
Hm maybe best to not cherry-pick this then since we already have it? |
adincebic
deleted the
adin/cherry-pick-15da0d2eadfbfedf8b673b5eb0903080c35111e1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 26.0 beta 5 has isolated this plugin to its own subdirectory and Xcode only passes it to the compiler when building test targets (previous versions had a symlink to make the default path work, but beta 5 removed that symlink). We don't want to make that distinction in our rules, so it's fine to just unconditionally pass it.
Cherry pick: 15da0d2eadfbfedf8b673b5eb0903080c35111e1