Skip to content

Conversation

@tillig
Copy link
Member

@tillig tillig commented Mar 12, 2024

Two scenarios had incorrect nullable annotations:

  1. When identifying a tenant (TryIdentifyTenant), if the tenant was not successfully identified, the output tenant ID should be allowed to be null.
  2. When configuring a tenant lifetime scope, ConfigureTenant should allow a null tenant ID to indicate the "default tenant."

As part of this I enabled nullable annotations on the unit test projects to ensure things were lining up and allow us to see the nullable warnings when violations in test fixtures occur.

Includes a semver update from 8.0.1 => 8.0.2 for this fix. (My commit message has a typo. 😦 )

@codecov
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (39f9710) to head (3ea67e1).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #39   +/-   ##
========================================
  Coverage    93.57%   93.57%           
========================================
  Files            5        5           
  Lines          109      109           
  Branches        28       28           
========================================
  Hits           102      102           
  Misses           3        3           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tillig tillig merged commit 1a7a9eb into develop Mar 12, 2024
@tillig tillig deleted the feature/nullable-fix branch March 12, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants